Fix bad xgrid along zero longitude when LND grid not same as ATM#379
Merged
mlee03 merged 1 commit intoNOAA-GFDL:mainfrom Jan 15, 2026
Merged
Conversation
- Address issue NOAA-GFDL#366 - When LND grid is not the same as ATM the xgrid is wrong along the Prime Meridian, E.g., if ATM is c96 and LND is c48, the xgrid cell areas are small by almost a factor of 2 along longitude=0 and the land mask has a spurious line along longitude=0 - The root cause is the Ocean grid is shifted right by 360 degree assuming that the land and atmos grids are the same which cause the atmXlnd exchange grid cells that are just to the left of the longitude=0 to be ignored. - The fix is to (re)apply the fixlon to shift Ocean grid based on the atmxlnd_x[l][0] rather than the atm_avg.
Contributor
Author
|
@ceblanton could you assign this to be reviewed (I don't seem to have permissions to do that). I suggest @mlee03 and @bensonr as reviewers. Thanks. |
Contributor
|
@nikizadehgfdl I added you to the github team that can write to the FRE repositories. Can you check? |
mlee03
approved these changes
Jan 7, 2026
Contributor
|
@nikizadehgfdl, could I request for the input and output files used to test this case? I want to make sure FMSgridtools/make_coupler_mosaic produces the correct xgrid |
Contributor
Author
|
@mlee03, the input files are in so, the fix can be tested with the following command line on PAN (an105): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--land_mosaic#366Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses