Skip to content

Bring in -check all and -ftrapuv to DEBUG intell builds#386

Merged
vithikashah001 merged 6 commits intoNOAA-GFDL:dev/emcfrom
BrianCurtis-NOAA:nco_debug_changes
Dec 3, 2025
Merged

Bring in -check all and -ftrapuv to DEBUG intell builds#386
vithikashah001 merged 6 commits intoNOAA-GFDL:dev/emcfrom
BrianCurtis-NOAA:nco_debug_changes

Conversation

@BrianCurtis-NOAA
Copy link

Description
Add DEBUG intel build flags to meet some NCO standard in ops

How Has This Been Tested?
This will be tested using the UFSWM regression testing system.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@BrianCurtis-NOAA BrianCurtis-NOAA marked this pull request as ready for review July 29, 2025 13:48
Copy link

@rem1776 rem1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Intel -check flag with no arguments defaults to the all option, so i don't think this really changes anything but can't hurt to be more explicit.

@bensonr
Copy link
Contributor

bensonr commented Dec 1, 2025

@BrianCurtis-NOAA - the default behavior of -check is the same as -check all. You may want to consider whether you want the -check uninit option as that is no longer included with the -check all option see here. Also, pay attention to the link-time note for LLVM.

@BrianCurtis-NOAA
Copy link
Author

@BrianCurtis-NOAA - the default behavior of -check is the same as -check all. You may want to consider whether you want the -check uninit option as that is no longer included with the -check all option see here. Also, pay attention to the link-time note for LLVM.

Thanks for this Rusty! It seems the check for uninit is causing problems with ifx, so i'll let it stay with defaults so we don't bring in more issues when/if we try newest intel. Let me go through and make modifications for -check all back to just -check.

@FernandoAndrade-NOAA
Copy link

Testing for #2789 is complete, please continue with merging, thank you.

@vithikashah001 vithikashah001 merged commit bd2b399 into NOAA-GFDL:dev/emc Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants