Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Jan 6, 2026

Description

Prefer the new constructor of QuantityFactory over the deprecated call to QuantityFactory.from_backend(...). This removes a bunch of deprecation warnings in tests.

See NOAA-GFDL/NDSL#228 for context.

/cc @FlorianDeconinck

How Has This Been Tested?

Search and manual replace of from_backend within pyFV3. CI is still green.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

Prefer the new constructor of `QuantityFactory` over the deprecated call
to `QuantityFactory.from_backend(...)`. This removes a bunch of deprecation
warnings in tests.

See NOAA-GFDL/NDSL#228 for context.
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@romanc
Copy link
Collaborator Author

romanc commented Jan 13, 2026

Someone else needs to merge on my behalf, I don't have permission to do so.

@fmalatino fmalatino added this pull request to the merge queue Jan 13, 2026
Merged via the queue into NOAA-GFDL:develop with commit 66b11e8 Jan 13, 2026
5 checks passed
@romanc romanc deleted the romanc/quantity-factory-update branch January 13, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants