fully integrated physics#77
Merged
vithikashah001 merged 14 commits intoNOAA-GFDL:mainfrom Jan 15, 2026
Merged
Conversation
gaokun227
approved these changes
Jan 7, 2026
lharris4
approved these changes
Jan 9, 2026
Contributor
lharris4
left a comment
lharris4
left a comment
There was a problem hiding this comment.
Also nicely done. Do note that the implicit LM4 coupling @JosephMouallem has been working on will conflict with these updates as it requires the physics driver and PBL schemes to be split, so getting these to work together will require some more development.
| ! dqsfc1(:) = 0. | ||
|
|
||
| if (Model%do_shoc) then | ||
| if (Model%do_inline_pbl) then |
Contributor
There was a problem hiding this comment.
If anything this is a good illustration of how data flows within the driver for each particular scheme.
| endif | ||
|
|
||
| !--- turn off convection when the inline convection is activated | ||
| if (Model%do_inline_cnv) then |
Contributor
There was a problem hiding this comment.
Does the inline convection handle both shallow and deep convection?
laurenchilutti
approved these changes
Jan 15, 2026
vithikashah001
approved these changes
Jan 15, 2026
Contributor
|
@laurenchilutti @vithikashah001 This PR creates issues as reported by @MingjingTong-NOAA which wouldn't allow a successful compilation of the 'main' branches. |
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on the latest main branch and includes the fully integrated physics framework developed since the start of this effort. When running with the original physics configuration, results should remain unchanged.
To enable the integrated physics, add the following namelist:
&integ_phys_nml
do_fast_phys = .T.
do_inline_pbl = .T.
do_inline_cnv = .T.
do_inline_gwd = .T.
inline_cnv_flag = 2
inline_pbl_flag = 1
/
&sa_sas_nml
/
&sa_aamf_nml
/
&sa_tke_edmf_nml
/
&sa_tke_edmf_new_nml
/
&sa_gwd_nml
/
Fixes # (issue)
How Has This Been Tested?
This functionality has been exercised extensively throughout the development process. However, this final version has not yet been re-tested after merging the latest updates from main.
Checklist:
Please check all whether they apply or not