Support the new strict option to fre catalog build#552
Merged
Conversation
Also, rename 'fre catalog builder' to 'fre catalog build' for consistency and clarity.
Collaborator
|
Addresses #301 |
Ciheim
reviewed
Jul 29, 2025
Collaborator
There was a problem hiding this comment.
Looks ready to go but catalog validation will fail until latest validator updates are merged.
NOAA-GFDL/CatalogBuilder#128
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
==========================================
+ Coverage 68.63% 68.65% +0.02%
==========================================
Files 63 63
Lines 4282 4285 +3
==========================================
+ Hits 2939 2942 +3
Misses 1343 1343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ceblanton
commented
Jul 30, 2025
| - conda-forge::jsonschema | ||
| - conda-forge::metomi-rose | ||
| - conda-forge::nccmp | ||
| - conda-forge::numpy<2 |
Contributor
Author
There was a problem hiding this comment.
Shouldn't this dependency belong to catalogbuilder alone, not fre-cli?
ceblanton
commented
Jul 30, 2025
ilaflott
approved these changes
Jul 30, 2025
Member
|
fixes #301 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add the optional, default off, option to the catalog builder for strict validation.
Also, rename 'fre catalog builder' to 'fre catalog build' for consistency and clarity.
Issue ticket number and link (if applicable)
Uses this upstream (not yet merged) update NOAA-GFDL/CatalogBuilder#112
Checklist before requesting a review