Skip to content

Feature: Ability to set desired NetCDF output precision from config #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmalatino merged 4 commits into from
Mar 13, 2025
Merged

Feature: Ability to set desired NetCDF output precision from config #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb90cfe
Added configurable options for precision of NetCDF output
fmalatino Feb 25, 2025
d52ca50
Added in method for setting NetCDF output precision
fmalatino Mar 5, 2025
b6e08bb
Merging in NDSL local changes
fmalatino Mar 5, 2025
21a1b39
Updated NDSL to use NetCDF precision setting feature
fmalatino Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NDSL
Open in desktop
Submodule NDSL updated 1 files
+14 −2 ndsl/monitor/netcdf_monitor.py
16 changes: 16 additions & 0 deletions pace/diagnostics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@
from datetime import datetime, timedelta
from typing import List, Optional, Union

import numpy as np

from ndsl import Quantity
from ndsl.constants import RGRAV, Z_DIM, Z_INTERFACE_DIM
from ndsl.dsl.dace.orchestration import dace_inhibitor
from ndsl.dsl.typing import Float
from ndsl.filesystem import get_fs
from ndsl.grid import GridData
from ndsl.monitor import Monitor, ZarrMonitor
Expand Down Expand Up @@ -86,6 +89,7 @@ class DiagnosticsConfig:
names: List[str] = dataclasses.field(default_factory=list)
derived_names: List[str] = dataclasses.field(default_factory=list)
z_select: List[ZSelect] = dataclasses.field(default_factory=list)
precision: str = "Float"

def __post_init__(self):
if (len(self.names) > 0 or len(self.derived_names) > 0) and self.path is None:
Expand All @@ -97,6 +101,11 @@ def __post_init__(self):
"output_format must be one of 'zarr' or 'netcdf', "
f"got {self.output_format}"
)
if self.precision not in ["Float", "float32", "float64"]:
raise ValueError(
"precision must be one of 'Float', 'float32', or 'float64"
f"got {self.precision}"
)

def diagnostics_factory(self, communicator: Communicator) -> Diagnostics:
"""
Expand All @@ -120,10 +129,17 @@ def diagnostics_factory(self, communicator: Communicator) -> Diagnostics:
mpi_comm=communicator.comm,
)
elif self.output_format == "netcdf":
if self.precision == "Float":
precision = Float
elif self.precision == "float32":
precision = np.float32
elif self.precision == "float64":
precision = np.float64
monitor = NetCDFMonitor(
path=self.path,
communicator=communicator,
time_chunk_size=self.time_chunk_size,
precision=precision,
)
else:
raise ValueError(
Expand Down