Skip to content

Remove Direct GT4Py Imports #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmalatino merged 12 commits into from
May 22, 2025
Merged

Remove Direct GT4Py Imports #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
677370c
removed direct gt4py imports
CharlesKrop Apr 25, 2025
e58ecad
linting
CharlesKrop May 1, 2025
682addc
added nametag to gtscript imports
CharlesKrop May 13, 2025
a10189f
linting
CharlesKrop May 13, 2025
126ab3f
changed @function to @gtfunction
CharlesKrop May 14, 2025
4c7f581
new NDSL version
CharlesKrop May 14, 2025
2ecb237
new NDSL branch
CharlesKrop May 14, 2025
65dc4d0
Merge remote-tracking branch 'NOAA-GFDL/develop' into unified_import
CharlesKrop May 14, 2025
402d54a
Merge remote-tracking branch 'NOAA-GFDL/develop' into unified_import
CharlesKrop May 15, 2025
2c854be
new NDSL version, removing extra imports in ndsl.dsl.gt4py that cause…
CharlesKrop May 16, 2025
f7d10c9
new NDSL version... again
CharlesKrop May 16, 2025
c06f338
Added name to CONTRIBUTORS.md
CharlesKrop May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ Turns into

### GT4Py stencils

We interface to `gt4py.cartesian.gtscript.stencil` through ndsl.dsl.stencil, specifically the FrozenStencil, that allows us to minimize runtime overhead in calling stencils.
We interface to `ndsl.dsl.gt4py.stencil` through ndsl.dsl.stencil, specifically the FrozenStencil, that allows us to minimize runtime overhead in calling stencils.
Copy link
Copy Markdown
Collaborator

@oelbert oelbert May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're changing this line maybe we could say "we interface to gt4py.cartesian stencils" since this redundancy seems a bit awkward

Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


```python
@gtstencil
Expand All @@ -132,11 +132,11 @@ For example, `FloatField[IJ]` for a 2D field of default floating point values.

### GTScript functions

These use the `@gtscript.function` decorator and the arguments do not include type
These use the `@gtfunction` decorator and the arguments do not include type
specifications. They will continue to not have type hinting, e.g.:

```python
@gtscript.function
@gtfunction
def get_bl(al, q):
```

Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ List format (alphabetical order): Surname, Name. Employer/Affiliation
* Fuhrer, Oliver. Allen Institute for AI.
* George, Rhea. Allen Institute for AI.
* Harris, Lucas. GFDL.
* Lee, Mi Kyung. GFDL.
* Kropiewnicki, Charles. NASA.
* Kung, Chris. NASA.
* Lee, Mi Kyung. GFDL.
* Malatino, Frank. GFDL
* McGibbon, Jeremy. Allen Institute for AI.
* Niedermayr, Yannick. ETH.
Expand Down
2 changes: 1 addition & 1 deletion NDSL
Open in desktop
Submodule NDSL updated 10 files
+1 −0 ndsl/__init__.py
+4 −2 ndsl/constants.py
+1 −10 ndsl/dsl/gt4py/__init__.py
+9 −0 ndsl/dsl/stencil.py
+249 −149 ndsl/namelist.py
+4 −2 ndsl/quantity/__init__.py
+190 −0 ndsl/quantity/field_bundle.py
+25 −2 ndsl/stencils/basic_operations.py
+10 −0 tests/dsl/gt4py/test_gt4py_wrapper.py
+77 −0 tests/quantity/test_fieldbundle.py
Loading