[CI] Cache test_data for translate tests#41
Merged
FlorianDeconinck merged 1 commit intoNOAA-GFDL:developfrom Feb 12, 2025
Merged
[CI] Cache test_data for translate tests#41FlorianDeconinck merged 1 commit intoNOAA-GFDL:developfrom
FlorianDeconinck merged 1 commit intoNOAA-GFDL:developfrom
Conversation
d6c686e to
cc7fb8e
Compare
Currently, translate tests go and fetch test_data/ from scratch every run. Every now and then, the server isn't available. This PR caches test_data/ as part of the translate test workflow.
58e2510 to
8455f45
Compare
Collaborator
Author
|
@FlorianDeconinck Another quick PR to tie up loose ends before we start the new dev cycle. I might put in something similar in the DaCe workflow once we re-enable these tests on DaCe's mainline branch. For now, I think we don't run enough DaCe tests that this would be justified. |
FlorianDeconinck
approved these changes
Feb 10, 2025
Collaborator
FlorianDeconinck
left a comment
There was a problem hiding this comment.
LGTM. Hold for NOAA review
fmalatino
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, translate tests go and fetch test_data/ from scratch every run. We had issues with data fetching in the past so I put in a cache under the assumption that GH cache servers are very reliable. They are also closer (in a network sense) to the executing machines, leading to slightly faster transfer times (not that this would matter in the 30min runtime that we are looking at).
How Has This Been Tested?
Checklist: