Skip to content

Comments

Cleanup: remove stale version variable and fix typos in comments#44

Merged
FlorianDeconinck merged 2 commits intoNOAA-GFDL:developfrom
romanc:romanc/remove-version-fix-typos
Feb 28, 2025
Merged

Cleanup: remove stale version variable and fix typos in comments#44
FlorianDeconinck merged 2 commits intoNOAA-GFDL:developfrom
romanc:romanc/remove-version-fix-typos

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Feb 28, 2025

Description

This PR removes an old/stale hard-coded version number from pyFV3/__init__.py and fixes a bunch of typos in comments.

How Has This Been Tested?

Ran pre-commit locally 😉

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

@romanc
Copy link
Collaborator Author

romanc commented Feb 28, 2025

@FlorianDeconinck random stuff I found while digging in the pyFV3 stencils during the dace bridge debug sessions. Happy Friday afternoon!

Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck merged commit 3466d21 into NOAA-GFDL:develop Feb 28, 2025
4 checks passed
@romanc romanc deleted the romanc/remove-version-fix-typos branch March 3, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants