No boost dependency anymore#62
Merged
FlorianDeconinck merged 1 commit intoNOAA-GFDL:developfrom May 30, 2025
Merged
Conversation
Newer GT4Py versions ship with a vendored in version of the boost header file that it needs. And since NDSL updated its GT4Py version, we don't need to install boost anymore in the `Dockerfile` for PyFV3. Not sure if anyone uses the docker version, but it's easy enough to just clean up.
Collaborator
Author
|
@oelbert I read you were waiting for this happen for a long time. Please take the pleasure in reviewing. /cc @FlorianDeconinck FYI |
4 tasks
bensonr
approved these changes
May 30, 2025
fmalatino
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Newer GT4Py versions ship with a vendored in version of the boost header file that it needs. And since NDSL updated its GT4Py version, we don't need to install boost anymore in the
Dockerfilefor PyFV3. Not sure if anyone uses the docker version, but it's easy enough to just clean up.For the record: The relevant GT4Py update in NDSL was done in NOAA-GFDL/NDSL#150.
How Has This Been Tested?
By doing a self-review of the code changes.
Checklist: