Skip to content

No boost dependency anymore#62

Merged
FlorianDeconinck merged 1 commit intoNOAA-GFDL:developfrom
romanc:romanc/no-boost-anymore
May 30, 2025
Merged

No boost dependency anymore#62
FlorianDeconinck merged 1 commit intoNOAA-GFDL:developfrom
romanc:romanc/no-boost-anymore

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented May 30, 2025

Description

Newer GT4Py versions ship with a vendored in version of the boost header file that it needs. And since NDSL updated its GT4Py version, we don't need to install boost anymore in the Dockerfile for PyFV3. Not sure if anyone uses the docker version, but it's easy enough to just clean up.

For the record: The relevant GT4Py update in NDSL was done in NOAA-GFDL/NDSL#150.

How Has This Been Tested?

By doing a self-review of the code changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

Newer GT4Py versions ship with a vendored in version of the boost header
file that it needs. And since NDSL updated its GT4Py version, we don't
need to install boost anymore in the `Dockerfile` for PyFV3. Not sure if
anyone uses the docker version, but it's easy enough to just clean up.
@romanc
Copy link
Collaborator Author

romanc commented May 30, 2025

@oelbert I read you were waiting for this happen for a long time. Please take the pleasure in reviewing.

/cc @FlorianDeconinck FYI

@bensonr bensonr removed the request for review from FlorianDeconinck May 30, 2025 13:08
@FlorianDeconinck FlorianDeconinck merged commit 4c3b96d into NOAA-GFDL:develop May 30, 2025
4 checks passed
@romanc romanc deleted the romanc/no-boost-anymore branch May 30, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants