ci: Effective cache sharing between PRs#81
Merged
fmalatino merged 2 commits intoNOAA-GFDL:developfrom Sep 8, 2025
Merged
Conversation
actions/cache takes care of this already (even if we just do the lookup and don't actually download the cache).
fmalatino
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Caching in GHA workflows is currently sub-optimal because we didn't understand the rules of when to create caches that can be reused. GitHub imposes the following rules on cache sharing. Caches can be restored by a workflow if
We currently save and restore caches from PRs, which means we get the cache boost from 1) starting with the second run of a PR. Since we use a merge queue, we never run PR workflows on merge to
develop. We thus never profit from the second case. This PR "solves" the issue by having an explicit cache creation workflow that runs when ever we merge intodevelop. This PR will create caches that can be reused (as intended by 2) above) by any PR targeting thedevelopbranch.The translate test workflow of this repository is re-used in other repository as a hook. This PR should (if I understand the docs correctly) generate translate test data caches that can be re-used by workflows from other repositories.
How Has This Been Tested?
This is a propagation of PR NOAA-GFDL/NDSL#202 in NDSL, which works as advertised. I'll double check after the first run that this also works as intended in this repository. If not, I'll do follow-up PRs in a timely manner.
Checklist: