feat: de-duplicate queued messages for not-yet-open channel#6
Merged
mackenzie-grimes-noaa merged 3 commits intomainfrom Feb 17, 2025
Merged
feat: de-duplicate queued messages for not-yet-open channel#6mackenzie-grimes-noaa merged 3 commits intomainfrom
mackenzie-grimes-noaa merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
package.jsonChanges
destinationandeventClass), only saving the most recent messageExplanation
This protects receiving channels (apps) from jittery behavior when they do come online and connect via MUPPET/WebRTC.
E.g. if a sender fires multiple messages with
eventClass: 'SENDER_APP.USER_SELECTED'before a receiving app is online, the receiver would previously attempt to process all these messages, which could lead to a jumpy user experience/UI state. Now only the most recent message will take effect in the receiver.