NGWPC NWM PI-3 Formulation Selection Delivery 2025-11-21#22
Open
cmaynard-ngwpc wants to merge 499 commits intoNOAA-OWP:masterfrom
Open
NGWPC NWM PI-3 Formulation Selection Delivery 2025-11-21#22cmaynard-ngwpc wants to merge 499 commits intoNOAA-OWP:masterfrom
cmaynard-ngwpc wants to merge 499 commits intoNOAA-OWP:masterfrom
Conversation
Disable conda buffering Clean up the download utilities
Clean up the download utilities" Rename base file
Add should_process_hours function
Lots of refactoring to forcing extraction scripts See merge request NGWPC/nwm-ngen/ngen-forcing!90
… output as the streamflow and HRRR files as atmospheric forcings for SCHISM, 2) Added the coastal pre-processing scripts and parameters files shared by OWP.
Ensure that lookback and lagback are passed as int See merge request NGWPC/nwm-ngen/ngen-forcing!92
NGWPC-1356 Develop algorithms and tools to preprocess T-route streamflow output for input to SCHISM See merge request NGWPC/nwm-ngen/ngen-forcing!91
Factor out run_conda_command to separate module; Other cleanup See merge request NGWPC/nwm-ngen/ngen-forcing!93
… script. This update enables the full forecase use case workflow to be run successfully.
…nto 'development' Updated the master script and fixed errors in the OWP makeAtmoHRRR.py script.... See merge request NGWPC/nwm-ngen/ngen-forcing!94
…pt for HRRR data extraction and for the Lower Colorado River ngen simulation. The Lower Colorado River test data should be downloaded from s3, 3) Updated the forecast run scripts to use the Singularity container. 4) Updated makeAtmoHRRR.py. 5) Next will create a confluence and update the scripts here accordingly.
1)Updated Dockerfile.ngencoastal for OE deployment, 2) Added run script for... See merge request NGWPC/nwm-ngen/ngen-forcing!95
Fix script name See merge request NGWPC/nwm-ngen/ngen-forcing!96
Fix MRMS Radar script See merge request NGWPC/nwm-ngen/ngen-forcing!97
… the streamflow simulations. 2) a few bug fixes, 3) removed scripts for making mesh, extracting forcing and running ngen.
…ing to bypass forcing_extraction
IForecast validation root dir
…emoving scratch files.
ngwpc 7354 - Fixing unstructured mesh variables node/element locations
… to the current time
fixing logic for supplemental radar forcing_extraction time handling
…-time Reduce unnecessary model runs (NGWPC-8671)
Klarkin ana times
Update aorc and nwm paths
cmaynard-ngwpc
changed the title
|
In summary, our team’s QA assess of this PR is that it requires several revisions and additions. As a result, our recommendation is that it not be approved or merged in its current form. Many good changes were made, especially to code within the four pre-existing top-level code directories (e.g., ESMF_Mesh_Domain_Configuration_Production). However, there are still some significant problems, and the documentation is inadequate and in some places incorrect. More detailed assessment can be found on the associated NWM QA/QC issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensive improvements across the forcing engine, coastal workflows, CI/CD pipelines, Docker and Singularity container builds, and time-handling logic for multiple data sources including AnA, MRMS, HRRR, AORC, and NWM. Major work includes substantial enhancements to supplemental precipitation handling, expanded support for regional workflows (Alaska, Puerto Rico, CONUS retrospective), merged SFINCS and SCHISM preprocessing pipelines, and numerous fixes to forcing extraction, mesh creation, BMI wrappers, and overall data-downloading utilities. The commits also introduce new configuration templates, improved exception handling, restructured scripts, refined directory and path management, added use cases, and expanded logging. Significant cleanup was performed—including removing problematic files, consolidating duplicated logic, and updating licenses and documentation—while CI/CD saw repeated refinements to streamline builds and integrate new coastal components. Overall, these changes advance workflow stability, modularity, compatibility with new containers and clusters, and broader support for high-resolution and multi-model forecasting workflows.