NGWPC NWM PI-3 Formulation Selection Delivery 2025-11-21#123
Open
cmaynard-ngwpc wants to merge 56 commits intoNOAA-OWP:mainfrom
Open
NGWPC NWM PI-3 Formulation Selection Delivery 2025-11-21#123cmaynard-ngwpc wants to merge 56 commits intoNOAA-OWP:mainfrom
cmaynard-ngwpc wants to merge 56 commits intoNOAA-OWP:mainfrom
Conversation
Ngwpc 4426 mkarim See merge request NGWPC/nwm-ngen/noah-owp-modular!1
Text file containing repository version number and date See merge request NGWPC/nwm-ngen/noah-owp-modular!2
Development Branch Merge to release-candidate branch for Release rc-1.0.0 See merge request NGWPC/nwm-ngen/noah-owp-modular!4
…didate' Updated version file for release rc-1.0.0 See merge request NGWPC/nwm-ngen/noah-owp-modular!6
Release Candidate Branch Merge to main for Release 1.0.0 See merge request NGWPC/nwm-ngen/noah-owp-modular!7
Release 1.0.0 Merge to development See merge request NGWPC/nwm-ngen/noah-owp-modular!8
Added RTX licensing verbiage See merge request NGWPC/nwm-ngen/noah-owp-modular!9
Merge development into release-candidate for release rc-1.1.0 See merge request NGWPC/nwm-ngen/noah-owp-modular!10
Merge update_version_file_rc-1.1.0 into release-candidate for release rc-1.1.0 See merge request NGWPC/nwm-ngen/noah-owp-modular!11
Merge release-candidate into development for release rc-1.1.0 See merge request NGWPC/nwm-ngen/noah-owp-modular!12
Merge release-candidate into main for release 1.1.0 See merge request NGWPC/nwm-ngen/noah-owp-modular!13
Merge update_version_file_1.1.0 into main for release 1.1.0 See merge request NGWPC/nwm-ngen/noah-owp-modular!14
Merge main into development for release 1.1.0 See merge request NGWPC/nwm-ngen/noah-owp-modular!15
Merge main into release-candidate for release 1.1.0 See merge request NGWPC/nwm-ngen/noah-owp-modular!16
Adding Log Level See merge request NGWPC/nwm-ngen/noah-owp-modular!3
… WARNING to SEVERE. Refactor for consistency across modules
…lopment' Add check for logging enabled, change log levels ERROR to WARNING and WARNING to SEVERE See merge request NGWPC/nwm-ngen/noah-owp-modular!17
Merge development into release-candidate for release 3.1.1.2.0-rc1 See merge request NGWPC/nwm-ngen/noah-owp-modular!18
Remove superfluous print when write_log exists. Fix logger rtoa subroutine. See merge request NGWPC/nwm-ngen/noah-owp-modular!19
Merge release-candidate into development for release 3.1.1.2.0-rc2 See merge request NGWPC/nwm-ngen/noah-owp-modular!20
Merge OWP Github main See merge request NGWPC/nwm-ngen/noah-owp-modular!21
Fix compiler warning See merge request NGWPC/nwm-ngen/noah-owp-modular!22
Delete version.txt See merge request NGWPC/nwm-ngen/noah-owp-modular!23
…eafactored some functions in StateSerialization
…ssinging for TRANSFER.
Serialization and get/set value functions for NOAH-OWP-MODULAR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement and refine initial serialization and deserialization in the BMI for state saving, including adoption of transfer_values_from_mp, proper allocation/deallocation, serialization_size handling, and full support for all potential variables. Logging was standardized with hierarchical levels, redundant prints removed, and standalone logger usage documented and tested. Compiler warnings, integer division issues, and platform-specific fixes were addressed, while build instructions, Makefiles, and messagepack integration were updated. Minor housekeeping included trimming strings, flushing stdout, deleting version.txt, and updating the license file to OWP government requirements.