Skip to content

NGWPC NWM PI-3 Formulation Selection Delivery 2026-02-25#14

Open
cmaynard-ngwpc wants to merge 153 commits intoNOAA-OWP:mainfrom
NGWPC:ngwpc-3.1.2.2.0
Open

NGWPC NWM PI-3 Formulation Selection Delivery 2026-02-25#14
cmaynard-ngwpc wants to merge 153 commits intoNOAA-OWP:mainfrom
NGWPC:ngwpc-3.1.2.2.0

Conversation

@cmaynard-ngwpc
Copy link
Contributor

@cmaynard-ngwpc cmaynard-ngwpc commented Feb 24, 2026

This pull request improves the robustness, flexibility, and usability of nwm-verf, with a focus on configuration handling, AnA (Analysis-and-Assimilation) support, and plotting resilience.

The PR adds support for environment/user variable substitution in paths, expands AnA capabilities (including negative and flexible lead times), improves graceful handling of missing observation data, and refines plotting behavior for large or sparse datasets. CI/CD coverage is also updated to align with NGWPC branch workflows.

Additions

Configuration & Workflow Support

  • Added support for environment and user variables in file paths.
  • Added backward compatibility for ngen_simulation.
  • Added support for:
    • String or integer lead times
    • Negative lead times for AnA runs
  • Added configuration support for separate_calibrated workflows.
  • Updated sample NWM forecast configuration files.
  • Added CI/CD support for ngwpc-candidate and ngwpc-release branches.

Visualization Enhancements

  • Added dynamic figure width support for metric tables.
  • Improved figure sizing for runs with a large number of datasets.

Changes

Correctness & Robustness

  • Fixed environment-variable substitution issues in configuration handling.
  • Improved handling of cases where no observation data is available, allowing workflows to exit gracefully.
  • Replaced missing data values with NaN for safer downstream processing.
  • Avoided NaNs in histogram plotting logic.
  • Fixed bugs related to AnA support.
  • Improved handling of edge cases such as win_size = 0.

Plotting & UX

  • Improved plot scaling and layout for large metric tables.
  • Ensured plots remain valid and readable even with sparse or missing data.

Removals

  • Removed an unused patch that was incompatible with PW and unnecessary for current workflows.
  • Removed commented-out legacy code paths.

cmaynard-ngwpc and others added 30 commits March 19, 2025 17:17
@cmaynard-ngwpc
Merge branch 'release-candidate' into 'development'
7a5f3b2 
Merge release-candidate 1.0.0-rc to development

See merge request NGWPC/nwm-ngen/ngen-verf!16
@yuqiong77
fixes for metric_subset="all"
9c86420
@cmaynard-ngwpc
Merge branch 'main' into 'development'
3c70edb 
Merge main into development for release 1.0.0

See merge request NGWPC/nwm-ngen/ngen-verf!20
@peterkronenberg-rtx
Change .gitignore
14eec9c
@peterkronenberg-rtx
Merge branch 'peter_gitignore' into 'development'
606c05e 
Change .gitignore

See merge request NGWPC/nwm-ngen/ngen-verf!21
@yuqiong77
add Jupyter notebook from demo
737d2de
@yuqiong77
change comment to indicate only shange_range is supported
0c7ba36
@yuqiong77
Merge branch 'yliu_change_comment' into 'development'
0c5ccf7 
Yliu change comment

See merge request NGWPC/nwm-ngen/ngen-verf!22
@yuqiong77
updates to address OWP concerns
6750a06
@yuqiong77
updates to address OWP concerns
ecbeb0d
@yuqiong77
Merge branch 'yliu_NGWPC-6418' into 'development'
63a8b59 
Yliu ngwpc 6418

See merge request NGWPC/nwm-ngen/ngen-verf!23
@yuqiong77
add support for oCONUS
95f9739
@yuqiong77
add support for oCONUS
8c2af60
@yuqiong77
remover username
8cc380a
@yuqiong77
Merge branch 'yliu_NGWPC-6418' into 'development'
d8133f5 
Yliu ngwpc 6418

See merge request NGWPC/nwm-ngen/ngen-verf!24
@yuqiong77
add teehr patch to fix AK issue
f213924
@yuqiong77
corrected typo in word patch
b4a7d39
@yuqiong77
minor updates to comments in sample config file
0ade274
@yuqiong77
minor updates to comments in sample config file
4427135
@yuqiong77
Merge branch 'yliu_fix_teehr' into 'development'
09fe505 
Yliu fix teehr

See merge request NGWPC/nwm-ngen/ngen-verf!25
@cmaynard-ngwpc
Merge branch 'development' into 'release-candidate'
3abcf21 
Merge development into release-candidate for release 3.1.1.1.0-rc1

See merge request NGWPC/nwm-ngen/ngen-verf!26
@yuqiong77
fix locations bug
c95542c
@yuqiong77
Merge branch 'yliu_NGWPC-6642_fetch-obs-err' into 'release-candidate'
fbce105 
fix locations bug

See merge request NGWPC/nwm-ngen/ngen-verf!27
@cmaynard-ngwpc
Merge branch 'release-candidate' into 'development'
163a984 
Merge release-candidate into development for release 3.1.1.1.0-rc2

See merge request NGWPC/nwm-ngen/ngen-verf!28
@yuqiong77
fixed error related to teehr metrics
7036ab7
@yuqiong77
Merge branch 'yliu_NGWPC-6679_teehr_metrics_error' into 'release-cand…
acf51b6 
…idate'

fixed error related to teehr metrics

See merge request NGWPC/nwm-ngen/ngen-verf!29
@cmaynard-ngwpc
Merge branch 'release-candidate' into 'development'
1258337 
Merge release-candidate into development for release 3.1.1.1.0-rc3

See merge request NGWPC/nwm-ngen/ngen-verf!30
@yuqiong77
fixed error in plotting event metrics
065dde0
@yuqiong77
Merge branch 'yliu_NGWPC-7105_event_metrics' into 'development'
5d0e0b8 
fixed error in plotting event metrics

See merge request NGWPC/nwm-ngen/ngen-verf!31
@miguelp1986
updated Dockerfile and created ci-cd.yml file for github migration
0f26aef
Yuqiong Liu and others added 30 commits January 8, 2026 16:56
minor updates to increase fig width for large number of datasets
9a6a4b6
@yuqiong77
Merge pull request #8 from NGWPC/yliu_NGWPC-9269_missing_obs
6837def 
Yliu ngwpc 9269 missing obs
@cnealen @miguelp1986
Add ngwpc-candidate and ngwpc-release branches to CI/CD workflow
b1614ce 
Added ngwpc-candidate and ngwpc-release to the trigger branches for both push and pull_request events in the GitHub Actions workflow.
@miguelp1986
Merge pull request #5 from NGWPC/feature/edit-ci-cd-workflow
3e39e58 
Add ngwpc-candidate and ngwpc-release branches to CI/CD workflow
@cmaynard-ngwpc
Merge pull request #9 from NGWPC/development
77df405 
Merge development into ngwpc-candidate for release 3.1.2.2.0-rc1
add support for AnA runs with negative lead times
a2e4296
support both string and integer lead times
2dc047a
backward compatibility for ngen_simulation
18c1d2b
@yuqiong77
Merge pull request #10 from NGWPC/yliu_NGWPC-9560_support_AnA
81793f8 
Yliu ngwpc 9560 support verification for AnA runs
update sample nwm forecast configuration file
29400ed
@yuqiong77
Merge pull request #11 from NGWPC/yliu_NGWPC-9560_support_AnA_new
bd4a80d 
Yliu ngwpc 9560 support AnA - add updated config file
fix bugs in supporting AnA
fc88c29
minor update to handle win_size=0
59c48ea
@yuqiong77
Merge pull request #12 from NGWPC/yliu_NGWPC-9560_support_AnA_bug_fix
ee0452b 
fix bugs in supporting AnA
@yuqiong77
Merge pull request #10 from NGWPC/yliu_NGWPC-9560_support_AnA
bfaff05 
Yliu ngwpc 9560 support verification for AnA runs
@yuqiong77
Merge pull request #11 from NGWPC/yliu_NGWPC-9560_support_AnA_new
7342cb3 
Yliu ngwpc 9560 support AnA - add updated config file
@yuqiong77
Merge pull request #12 from NGWPC/yliu_NGWPC-9560_support_AnA_bug_fix
f02a9ae 
fix bugs in supporting AnA
@yuqiong77
Merge pull request #13 from NGWPC/yliu_backport_ngwpc_candidate
64229cc 
Yliu backport ngwpc candidate
@cmaynard-ngwpc
Merge pull request #14 from NGWPC/ngwpc-candidate
8a9cbb2 
Merge ngwpc-candidate into development for release 3.1.2.2.0-rc2
add support for env and user variables in paths
2396c26
remove commented code
c9abbaf
@yuqiong77
Merge pull request #15 from NGWPC/yliu_NGWPC-9416_multi_user
8d95f57 
add support for env and user variables in paths
updates to exit gracefully when no obs data available
2ae36f4
@yuqiong77
Merge pull request #16 from NGWPC/yliu_NGWPC-NGWPC-9679_obs_data_error
9b90bd2 
updates to exit gracefully when no obs data available
support dynamic figure width for metric table
2e9b796
@yuqiong77
Merge pull request #17 from NGWPC/yliu_NGWPC-9631_metric_fig_width
9f6045f 
support dynamic figure width for metric table
fix substitution with env variables
14e9d27
@yuqiong77
Merge pull request #18 from NGWPC/yliu_NGWPC-9417_fix_substitution
7da4e46 
fix substitution with env variables
@yuqiong77
Merge pull request #19 from NGWPC/yliu_merged_PRs_for_realse
d1c28d0 
Yliu merged PRs for ngwpc-candidate
@cmaynard-ngwpc
Merge pull request #23 from NGWPC/ngwpc-candidate
d2bbef0 
Merge ngwpc-candidate into ngwpc-release for release 3.1.2.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cmaynard-ngwpc @yuqiong77 @peterkronenberg-rtx @miguelp1986 @cnealen