Skip to content

47 add option to retain ghost points in nested nemodatatrees - #50

Merged
oj-tooth merged 4 commits into
mainfrom
47-add-option-to-retain-ghost-points-in-nested-nemodatatrees
Aug 14, 2026
Merged

47 add option to retain ghost points in nested nemodatatrees#50
oj-tooth merged 4 commits into
mainfrom
47-add-option-to-retain-ghost-points-in-nested-nemodatatrees

Conversation

@oj-tooth

@oj-tooth oj-tooth commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Retain ghost points in nested NEMODataTrees including a hierarchy of domains.

  • Added option to use nbghost_child=None in from_paths() and from_datasets() constructors to enable users to optionally bypass clipping ghost points in child domains.
  • Updated the processing.py module _get_child_indices() function to fill ghost point parent indices with NaN values when located outside of the domain defined in the input nests dictionary.
  • Added new fixture factories to generate ORCA2 and ORCA2-AGRIF example NEMODataTree for unit testing.
  • Added new unit tests to verify behaviour when nbghost_child=None - ghost points are retained.
  • Updated documentation to reflect linssh parameter rename and include discussion on the use of vco when constructing a NEMODataTree.

Closes Issue #47

@oj-tooth oj-tooth added this to the Release v2026.08.01 milestone Aug 14, 2026
@oj-tooth oj-tooth self-assigned this Aug 14, 2026
@oj-tooth oj-tooth added the docs Improvements or additions to NEMO Cookbook documentation. label Aug 14, 2026
@oj-tooth oj-tooth linked an issue Aug 14, 2026 that may be closed by this pull request
2 tasks
@oj-tooth oj-tooth added feature Addition of new feature to NEMO Cookbook. tests Additions or improvements to NEMO Cookbook unit & integration tests. class: NEMODataTree Issues involving NEMODataTree behaviour or functionality. labels Aug 14, 2026
@oj-tooth
oj-tooth merged commit 00fe635 into main Aug 14, 2026
2 checks passed
@oj-tooth
oj-tooth deleted the 47-add-option-to-retain-ghost-points-in-nested-nemodatatrees branch August 14, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class: NEMODataTree Issues involving NEMODataTree behaviour or functionality. docs Improvements or additions to NEMO Cookbook documentation. feature Addition of new feature to NEMO Cookbook. tests Additions or improvements to NEMO Cookbook unit & integration tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[refactor] Add option to retain ghost points in nested NEMODataTrees

1 participant