Open
Conversation
hooni0918
reviewed
Jun 11, 2024
Member
hooni0918
left a comment
hooni0918
left a comment
There was a problem hiding this comment.
역시 오비는 다르다..!!!! 의존성 분리를 너무 잘해놓으셔서 눈호강 하고 갑니다
오늘도 행복하세요 :)
|
|
||
| import Foundation | ||
|
|
||
| final class AppDIContainer { |
Member
There was a problem hiding this comment.
와! 의존성분리를 하시다니 진짜 본격적으로 하셧군요! 역시 빡고수,,
Comment on lines
+24
to
+27
| init(viewModel: MainContentViewModel) { | ||
| self.viewModel = viewModel | ||
| super.init(nibName: nil, bundle: nil) | ||
| } |
| requestDetailInfo(code: code) { [weak self] detailData in | ||
| let detailViewController = DetailViewController() | ||
| detailViewController.detailView.configure(with: detailData) | ||
| private func bindViewModel() { |
Member
There was a problem hiding this comment.
의존성을 잘 분리하셧는데 이부분도 분리한김에 Coordinator 패턴을 적용해서 화면 리로드를 가져가봐도 좋을것같아요..! 츄라이츄라이
SeoyoungOhMe
approved these changes
Jun 15, 2024
SeoyoungOhMe
left a comment
SeoyoungOhMe
left a comment
There was a problem hiding this comment.
MVVM도 적용하고 과제 하시느라 고생하셨어요!! PR도 자세히 적으셔서 이해하기 수월했습니다!! 쵝오 💪
|
|
||
| var window: UIWindow? | ||
|
|
||
| let appDIContainer = AppDIContainer() |
Comment on lines
+8
to
+13
| import Foundation | ||
|
|
||
| protocol ContentRepository { | ||
| func getMovieInfo(completion: @escaping (Result<[Content], Error>) -> Void) | ||
| func getDetailInfo(code: String, completion: @escaping (Result<ContentDetail, Error>) -> Void) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👾 작업 내용
Domain
→ 프로젝트가 무엇으로 바뀌든, 이 부분이 존재함은 절대 변함이 없기 때문에 이렇게 정의 했어요!
Domain은 Data 영역에 의존관계를 가지면 안됩니다.
Repository에 대한의존을 가지면 안됩니다!
따라서 protocol로 선언하여 의존성을 역전시켜줍니다.
Data
Presentation
SceneDelegate
🚀 PR Point
🔗 Issue
Resolved #7