add integration example dependencies#4
Merged
ParsaTasbihgou merged 1 commit intoNP-Eng:Add-shieldingfrom Sep 12, 2025
Merged
Conversation
5 tasks
|
These examples were deprecated and now entirely deleted. Please disregard them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for the integration example (plus to lesser extent also the shielding test) you provided for w3f/Grant-Milestone-Delivery#1276 - I don't see any other dependency specification for these examples in the repo.
Uses latest dep versions except for
ethers- seems you're still using API of 5.x here, at least for integration example.I'll note though that the shieldtx signature produced is still incorrect - spits out 64 in lieu of 65 bytes. Without looking into it too deeply, I guess you forgot to add the signature type prefix byte: https://spec.polkadot.network/id-extrinsics#defn-extrinsic-signature, or are using some fork/version that omits these (less likely: you're missing parity byte for ecdsa sig).
🛡️ Simulating EVM shield operation... ❌ Error: Error: createType(ExtrinsicSignature):: Expected input with 65 bytes (520 bits), found 64 bytes at createTypeUnsafe ([...]/nullifier-prime-2521/frontier/examples/node_modules/@polkadot/types-create/cjs/create/type.js:54:22) at TypeRegistry.createTypeUnsafe ([...]/nullifier-prime-2521/frontier/examples/node_modules/@polkadot/types/cjs/create/registry.js:230:52) at Type.sign ([...]/nullifier-prime-2521/frontier/examples/node_modules/@polkadot/types/cjs/extrinsic/v4/ExtrinsicSignature.js:148:98) at Type.sign ([...]/nullifier-prime-2521/frontier/examples/node_modules/@polkadot/types/cjs/extrinsic/v4/Extrinsic.js:74:24) at Submittable.sign ([...]/nullifier-prime-2521/frontier/examples/node_modules/@polkadot/types/cjs/extrinsic/Extrinsic.js:298:20) at [...]/nullifier-prime-2521/frontier/examples/node_modules/@polkadot/api/cjs/submittable/createClass.js:152:26 at doInnerSub ([...]/nullifier-prime-2521/frontier/examples/node_modules/rxjs/dist/cjs/internal/operators/mergeInternals.js:22:31) at outerNext ([...]/nullifier-prime-2521/frontier/examples/node_modules/rxjs/dist/cjs/internal/operators/mergeInternals.js:17:70) at OperatorSubscriber._this._next ([...]/nullifier-prime-2521/frontier/examples/node_modules/rxjs/dist/cjs/internal/operators/OperatorSubscriber.js:33:21) at Subscriber.next ([...]/nullifier-prime-2521/frontier/examples/node_modules/rxjs/dist/cjs/internal/Subscriber.js:51:18)