Open
Conversation
…arning into geo_deep_learning_dask
added 4 commits
August 7, 2024 16:41
Author
CharlesAuthier
previously approved these changes
Aug 8, 2024
Collaborator
There was a problem hiding this comment.
Do you think an RGBN test can be useful?
valhassan
requested review from
LucaRom,
mpelchat04,
ms888ekb,
remtav and
valhassan
mpelchat04
reviewed
Aug 30, 2024
| logging.info(f'\nReading image: {aoi.aoi_id}') | ||
| raster = aoi.raster | ||
| geo_inference(raster, tiff_name=aoi.aoi_id, patch_size=chunk_size) | ||
| geo_inference(tiff_image=str(aoi.raster_name), patch_size=chunk_size) |
Collaborator
There was a problem hiding this comment.
Geo_inference call does not have the argument tiff_image but rather inference_input
https://github.com/NRCan/geo-inference/blob/main/geo_inference/geo_inference.py#L103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting your PR and helping us with GDL.
Please read the template below, fill it out as appropriate, and make additional changes to your code as needed.
Please feel free to submit your PR even if it doesn't satisfy all of the requirements below.
If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively.
After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.
Description
This PR intends to include dask for image contrast enhancement to speed up the pre-processing step.
In addition, it has removed the download step of reading stack data and instead it is streaming data directly to arrays.
Dependencies are:
Type of change
What types of changes does your code introduce? Put an
xin all the boxes that apply:How Has This Been Tested?
Testing part is an ongoing step.
Checklist:
If you're unsure about any of these, don't hesitate to ask. We're here to help!
If your PR does not fulfill all of the requirements in the checklist above, that's OK! If you need help, @-mention a maintainer and/or add the Status: Help Needed label.