Skip to content

Add docstrings to all exported symbols#1632

Open
luke-kiernan wants to merge 3 commits intomainfrom
lk/docstrings-for-exports
Open

Add docstrings to all exported symbols#1632
luke-kiernan wants to merge 3 commits intomainfrom
lk/docstrings-for-exports

Conversation

@luke-kiernan
Copy link
Copy Markdown
Contributor

Summary

  • Adds docstrings for 49 exported types and functions that were missing documentation
  • Abstract types for dynamic generator components: AVR, Machine, PSS, Shaft, TurbineGov
  • Abstract types for dynamic inverter components: Converter, DCSource, Filter, FrequencyEstimator, InnerControl, OutputCurrentLimiter
  • Reserve/contingency types: AbstractReserve, ReserveNonSpinning, Contingency, Outage, PowerPlant
  • Structs: ServiceContributingDevices, TurbineConnectedDevices
  • Scoped enums: StateTypes, CombinedCycleConfiguration (uses @doc macro)
  • Dynamic component accessors: get_machine, get_shaft, get_avr, get_prime_mover, get_pss, get_frequency_droop, get_converter, get_outer_control, get_inner_control, get_dc_source, get_freq_estimator, get_filter
  • Utility functions: is_market_bid_curve, set_upstream_turbine!, set_downstream_turbine!, remove_component_from_subsystems!, get_component_uuids, remove_components!, check_ac_transmission_rate_values, parse_matlab_file, parse_matlab_string
  • Docstrings include @ref links for cross-referencing in built documentation

Test plan

  • Docs build passes with no new errors
  • Formatter run clean

🤖 Generated with Claude Code

Adds docstrings for 49 exported types and functions that were missing them,
including dynamic generator/inverter component abstract types (AVR, Machine,
PSS, Shaft, TurbineGov, Converter, DCSource, Filter, FrequencyEstimator,
InnerControl, OutputCurrentLimiter), reserve types, contingency types,
scoped enums (StateTypes, CombinedCycleConfiguration), accessor functions,
and utility functions. Uses @doc macro for @scoped_enum types.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.03%. Comparing base (1617cc3) to head (cd422fb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1632   +/-   ##
=======================================
  Coverage   84.03%   84.03%           
=======================================
  Files         203      203           
  Lines       10462    10462           
=======================================
  Hits         8792     8792           
  Misses       1670     1670           
Flag Coverage Δ
unittests 84.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/PowerSystems.jl 0.00% <ø> (ø)
src/base.jl 88.94% <ø> (ø)
src/definitions.jl 100.00% <ø> (ø)
src/models/cost_functions/MarketBidCost.jl 93.18% <ø> (ø)
src/models/dynamic_generator.jl 69.56% <ø> (ø)
src/models/dynamic_generator_components.jl 100.00% <ø> (ø)
src/models/dynamic_inverter.jl 86.20% <ø> (ø)
src/models/services.jl 0.00% <ø> (ø)
src/models/supplemental_setters.jl 37.50% <ø> (ø)
src/models/topological_elements.jl 60.00% <ø> (ø)
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Adds contingencies.jl, parsers/im_io/matlab.jl, and
supplemental_setters.jl to the appropriate @autodocs sections
so their new docstrings are included in the built documentation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@luke-kiernan
Copy link
Copy Markdown
Contributor Author

luke-kiernan commented Feb 17, 2026

The docs test errors because it's using the current version of IS, which lacks a docstring for ProductionVariableCostCurve. I have a PR open in IS that adds said docstring

@luke-kiernan luke-kiernan requested review from jd-lara and removed request for jd-lara February 17, 2026 15:32
@jd-lara jd-lara requested a review from rodrigomha February 18, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant