Skip to content

Conversation

@malihass
Copy link
Collaborator

@malihass malihass commented May 3, 2025

Fix #95

  • Look up the alpha threshold from phaseProperties
  • Lookup He for kla calculation
  • Make sure that Thermo properties are consistent across cases and resolve conflicts
  • Add comment in yaml files explaining where the properties (Especially WC and He coefficient) are from (@mjrahimi)
  • Make sure that Henry properties are consistent across cases and resolve conflicts
  • Make sure that dependencies are correctly handled when automating the global var writing (checked for disengagement only, but needs to be checked for all cases)
  • Some inputs are inconsistent, (mflowrate vs mflowrategas)

@malihass malihass marked this pull request as draft May 3, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Central location for Henry's constants

2 participants