Multipcm 13node #178
Open
Multipcm 13node #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jmaguire1 @mnblonsky
I closed the last multipcm pr as it had some sort of issues adding new changes.
I've added my current multi-pcm implementation. There have been quite a few changes since last time. All issues from last time have been largely resolved.
I've added:
Dynamic PCM capacitance based on temperature
Computed ha (W/K) values from a SA ratio (m^2/m^3 of total pcm volume) and an h (W/m^2K) value
Programmatic rc network calculations
An enthalpy and capacitance LUT from PCM measurements
Now adding pcm in the middle of the tank only (nodes 4-9) currently using a volume fraction of 0.5
And a bunch of diagnostic stats
The setpoint has been updated to 59C at the moment to ensure the PCM can actually melt as the experimental data we have used a rather high temp pcm.
There's this strange oscillation that occurs in the layers the pcm is in as it absorbs heat which seems odd that you can see in the Water Heater Node chart. The PCM doesn't show any detectable oscillation. My question is am I doing the dynamic capacitance calculation correctly or is there a different way of doing it that's more streamlined? It's in the TankWithMultiPCM Class where I reinitialize the state space model every timestep to recompute the rc network.