SmarAct migration #114
Open
SmarAct migration #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for two new device roles in an Ansible-based EPICS IOC deployment system:
- Wiener Crate - for SNMP-based monitoring and control of Wiener power supply crates
- SmarAct Motor Controllers - for MCS and MCS2 piezo motor positioning systems
Key Changes
- Added complete role implementations for
wienercrateandsmaractdevice types with templates, tasks, schemas, and examples - Introduced two new EPICS module configurations:
snmp_nscl_3cd2804andmotorsmaract_ab4dfeb - Included database files, MIB definitions, and configuration files for Wiener crate monitoring
- Created deployment variable files linking device roles to their required EPICS modules
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| roles/install_module/vars/snmp_nscl_3cd2804.yml | Module definition for SNMP support with NSCL variant |
| roles/install_module/vars/motorsmaract_ab4dfeb.yml | Module definition for SmarAct motor driver |
| roles/device_roles/wienercrate/* | Complete device role for Wiener crate SNMP monitoring |
| roles/device_roles/smaract/* | Complete device role for SmarAct motor controllers |
| roles/deploy_ioc/vars/wienercrate.yml | IOC deployment configuration for Wiener crates |
| roles/deploy_ioc/vars/smaract.yml | IOC deployment configuration for SmarAct controllers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{ device_roles_smaract_idle_poll_period }}, | ||
| {{ device_roles_smaract_disable_speed }}) | ||
| {% for i in range(ioc.num_axes) %} | ||
| smaraActMCSCreateAxis("$(PORT)", {{ i }}, {{ i }}) |
There was a problem hiding this comment.
Corrected spelling of 'smaraActMCSCreateAxis' to 'smarActMCSCreateAxis'. The function name has a typo with 'smara' instead of 'smarAct'.
Suggested change
| smaraActMCSCreateAxis("$(PORT)", {{ i }}, {{ i }}) | |
| smarActMCSCreateAxis("$(PORT)", {{ i }}, {{ i }}) |
| drvAsynIPPortConfigure("$(PORT)_ETH", "$(CONTROLLER_IP):55551", 0, 0, 0) | ||
| MCS2CreateController("$(PORT)", "$(PORT)_ETH", "$(NUM_AXES)", | ||
| {{ device_roles_smaract_moving_poll_period * 1000 }}, | ||
| {{ device_roles_smaract_moving_poll_period * 1000 }}, |
There was a problem hiding this comment.
Line 10 uses device_roles_smaract_moving_poll_period * 1000 but should likely use device_roles_smaract_idle_poll_period * 1000 based on the parameter naming convention and the non-MCS2 branch which uses separate moving and idle periods.
Suggested change
| {{ device_roles_smaract_moving_poll_period * 1000 }}, | |
| {{ device_roles_smaract_idle_poll_period * 1000 }}, |
Contributor
|
Substitution files need work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated SmarAct role from ioc-deploy-roles to nsls2.ioc_deploy