-
Notifications
You must be signed in to change notification settings - Fork 12
Modifications to support newer version of ADPhantom driver #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the ADPhantom device role configuration to use new API functions and parameters. The changes migrate from deprecated "miro" naming to "ADPhantom" naming conventions and add support for MAC address and network interface configuration.
- Updates template to use standardized variable names (
deploy_ioc_template_root_path,deploy_ioc_executable) - Replaces deprecated miro* function calls with ADPhantom* equivalents
- Adds MAC_ADDR and INTF environment variables for network configuration
- Reorganizes set_requestfile_path command to the beginning of the file
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| roles/device_roles/adphantom/templates/base.cmd.j2 | Updates variable names, replaces miro* functions with ADPhantom*, adds MAC_ADDR and INTF parameters to ADPhantomConfig, and reorganizes set_requestfile_path |
| roles/device_roles/adphantom/schema.yml | Adds MAC_ADDR and INTF as required environment variables |
| roles/device_roles/adphantom/example.yml | Provides example values for new MAC_ADDR and INTF environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
jennmald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note, for now pointed this at my fork, pending DiamondLightSource/ADPhantom#24