Skip to content

Conversation

@jwlodek
Copy link
Collaborator

@jwlodek jwlodek commented Nov 5, 2025

Note, for now pointed this at my fork, pending DiamondLightSource/ADPhantom#24

Copilot AI review requested due to automatic review settings November 5, 2025 17:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ADPhantom device role configuration to use new API functions and parameters. The changes migrate from deprecated "miro" naming to "ADPhantom" naming conventions and add support for MAC address and network interface configuration.

  • Updates template to use standardized variable names (deploy_ioc_template_root_path, deploy_ioc_executable)
  • Replaces deprecated miro* function calls with ADPhantom* equivalents
  • Adds MAC_ADDR and INTF environment variables for network configuration
  • Reorganizes set_requestfile_path command to the beginning of the file

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
roles/device_roles/adphantom/templates/base.cmd.j2 Updates variable names, replaces miro* functions with ADPhantom*, adds MAC_ADDR and INTF parameters to ADPhantomConfig, and reorganizes set_requestfile_path
roles/device_roles/adphantom/schema.yml Adds MAC_ADDR and INTF as required environment variables
roles/device_roles/adphantom/example.yml Provides example values for new MAC_ADDR and INTF environment variables

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@jennmald jennmald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thopkins32 thopkins32 merged commit c3bf055 into NSLS2:main Nov 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants