Skip to content

Conversation

@jwlodek
Copy link
Collaborator

@jwlodek jwlodek commented Nov 21, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 21, 2025 19:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds comprehensive support for the ADXSPD (X-SPRESS Detector) driver to the Ansible collection, enabling automated deployment and configuration of ADXSPD IOC instances.

Key Changes:

  • Added complete device role for ADXSPD including templates, schema, example configuration, and deployment tasks
  • Defined module dependency configuration for ADXSPD with version set to "latest"
  • Updated build tooling in Makefile and pixi.toml to use pixi run commands instead of direct script invocation

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
roles/install_module/vars/adxspd_latest.yml Defines ADXSPD module configuration with dependencies on adcompvision, adcore, and ffmpeg_server
roles/device_roles/adxspd/templates/base.cmd.j2 IOC startup command template with ADXSPDConfig setup and database loading for main detector and modules
roles/device_roles/adxspd/templates/auto_settings.req.j2 Auto-save request file template for ADXSPD settings and optional plugins
roles/device_roles/adxspd/tasks/main.yml Ansible tasks to install base.cmd and auto_settings.req templates with proper permissions
roles/device_roles/adxspd/schema.yml Schema definition for ADXSPD device type with required and optional environment variables
roles/device_roles/adxspd/example.yml Example configuration for ADXSPD device instance deployment
roles/device_roles/adxspd/README.md Basic documentation for the ADXSPD Ansible role
roles/deploy_ioc/vars/adxspd.yml IOC deployment variables including template paths, request files, and device-specific environment settings
pixi.toml Updated task definitions to use direct Python script invocation instead of Makefile targets
Makefile Modified to use pixi run commands for all tasks, delegating execution to pixi.toml definitions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant