Skip ADKinetix compilation and add verification #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds verification configuration for the ADKinetix device role by introducing a new example configuration and verification schema. The PR sets the module to skip compilation (due to proprietary SDK requirements) and defines verification rules to ensure proper IOC deployment.
- Skip compilation is enabled for ADKinetix module (requires proprietary SDK)
- Adds verification rules to check for proper IOC boot files and template rendering
- Provides example configuration for a Kinetix detector with camera dimensions 3200x3200
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| roles/device_roles/adkinetix/examples/kinetix-det1/verify.yml | Adds verification schema to validate IOC file generation, template rendering, and file permissions for the ADKinetix role |
| roles/device_roles/adkinetix/examples/kinetix-det1/config.yml | Provides example configuration for a Kinetix detector instance with required environment variables (PREFIX, PORT, XSIZE, YSIZE) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jwlodek
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.