-
Notifications
You must be signed in to change notification settings - Fork 12
Add role for ADURL driver #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new Ansible role for deploying ADURL (Area Detector URL) driver IOC instances. ADURL is an areaDetector driver that can stream images from URL sources.
Key changes:
- Added ADURL module definition with version 1c725ed and its dependencies
- Created device role with startup scripts, autosave configuration, and schema validation
- Configured IOC deployment variables with appropriate defaults for the URL driver
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| roles/install_module/vars/adurl_1c725ed.yml | Defines the ADURL module with version, URL, and dependencies (adsupport, adcompvision, adcore, adpluginbar, ffmpeg_server) |
| roles/device_roles/adurl/templates/base.cmd.j2 | IOC startup script template for initializing URLDriver and loading database records |
| roles/device_roles/adurl/templates/auto_settings.req.j2 | Autosave request file template for preserving IOC settings across restarts |
| roles/device_roles/adurl/tasks/main.yml | Ansible tasks for deploying base.cmd template |
| roles/device_roles/adurl/schema.yml | Schema validation for adurl IOC configuration requiring ENGINEER and PREFIX environment variables |
| roles/device_roles/adurl/example.yml | Example configuration showing how to instantiate an adurl IOC |
| roles/device_roles/adurl/README.md | Brief documentation describing the role's purpose |
| roles/deploy_ioc/vars/adurl.yml | IOC deployment variables including executable name, paths, and device-specific environment defaults |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the test role needs to be updated to pass.
|
Yeah, the container image we use seems to have been broken when I made a new release with RH9 support. Fixing now and I'll rerun CI... |
No description provided.