Skip to content

Conversation

@jwlodek
Copy link
Collaborator

@jwlodek jwlodek commented Jan 9, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Ansible role for deploying ADURL (Area Detector URL) driver IOC instances. ADURL is an areaDetector driver that can stream images from URL sources.

Key changes:

  • Added ADURL module definition with version 1c725ed and its dependencies
  • Created device role with startup scripts, autosave configuration, and schema validation
  • Configured IOC deployment variables with appropriate defaults for the URL driver

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
roles/install_module/vars/adurl_1c725ed.yml Defines the ADURL module with version, URL, and dependencies (adsupport, adcompvision, adcore, adpluginbar, ffmpeg_server)
roles/device_roles/adurl/templates/base.cmd.j2 IOC startup script template for initializing URLDriver and loading database records
roles/device_roles/adurl/templates/auto_settings.req.j2 Autosave request file template for preserving IOC settings across restarts
roles/device_roles/adurl/tasks/main.yml Ansible tasks for deploying base.cmd template
roles/device_roles/adurl/schema.yml Schema validation for adurl IOC configuration requiring ENGINEER and PREFIX environment variables
roles/device_roles/adurl/example.yml Example configuration showing how to instantiate an adurl IOC
roles/device_roles/adurl/README.md Brief documentation describing the role's purpose
roles/deploy_ioc/vars/adurl.yml IOC deployment variables including executable name, paths, and device-specific environment defaults

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@jennmald jennmald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the test role needs to be updated to pass.

@jwlodek
Copy link
Collaborator Author

jwlodek commented Jan 9, 2026

Yeah, the container image we use seems to have been broken when I made a new release with RH9 support. Fixing now and I'll rerun CI...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants