Skip to content

Conversation

@jwlodek
Copy link
Collaborator

@jwlodek jwlodek commented Jan 9, 2026

Some env vars were missing, so adding them as defaults, and to the schema.

Copilot AI review requested due to automatic review settings January 9, 2026 17:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes missing environment variables in the ADPhantom role that were discovered during deployment at HEX. The changes add default environment variables to the deployment configuration and update the schema to allow both IP addresses and hostnames for the CAMERA_IP field.

Key changes:

  • Updated schema validation to accept both IP addresses and hostnames for CAMERA_IP
  • Added default environment variables for ADPhantom IOC deployment (image dimensions, buffer sizes, ports, etc.)
  • Updated example configuration with current engineer information

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
roles/device_roles/adphantom/schema.yml Changed CAMERA_IP validation from str() to any(ip(), hostname()) to support both IP addresses and hostnames
roles/device_roles/adphantom/example.yml Updated ENGINEER field from "K. Barry" to "J. Wlodek" in the example configuration
roles/deploy_ioc/vars/adphantom.yml Added deploy_ioc_device_specific_env section with 12 default environment variables (QSIZE, XSIZE, YSIZE, NCHANS, CBUFFS, MAX_THREADS, EPICS_DB_INCLUDE_PATH, NELEMENTS, PORT, CTRL_PORT, DATA_PORT) needed for ADPhantom IOC deployment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@sligara7 sligara7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

@sligara7 sligara7 merged commit 445740d into NSLS2:main Jan 12, 2026
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants