Skip to content

feat: add score screen#110

Draft
kevinlee-06 wants to merge 14 commits intomainfrom
score-screen-and-student-service
Draft

feat: add score screen#110
kevinlee-06 wants to merge 14 commits intomainfrom
score-screen-and-student-service

Conversation

@kevinlee-06
Copy link
Copy Markdown
Contributor

No description provided.

@rileychh-dokploy-riley-ntut-npc
Copy link
Copy Markdown

rileychh-dokploy-riley-ntut-npc bot commented Feb 26, 2026

Dokploy Preview Deployment

Name Status Preview Updated (UTC)
API Docs ✅ Done Preview URL 2026-03-22T16:01:29.003Z

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2026

PR Preview Builds

Build Number: 730
Commit: aea3466
Message: chore: extract score screen hardcoded strings to i18n

Deploy

  • Android (Firebase App Distribution)
  • iOS (TestFlight)

Android (Firebase App Distribution)

Install build 730

@rileychh rileychh changed the base branch from main to course-table February 26, 2026 20:04
@kevinlee-06 kevinlee-06 requested a review from Copilot February 26, 2026 22:28
@kevinlee-06
Copy link
Copy Markdown
Contributor Author

Screenshot_20260227-062705

@Dao-you
Copy link
Copy Markdown
Contributor

Dao-you commented Feb 26, 2026

@kevinlee-06 What will happen if the average and GPA data are not available yet?

This comment was marked as outdated.

@kevinlee-06
Copy link
Copy Markdown
Contributor Author

@kevinlee-06 What will happen if the average and GPA data are not available yet?

Re: @Dao-you In cases where the GPA data is unavailable, the _formatDouble() function is designed to return -.

@rileychh rileychh changed the title feat: score sceen feat: add score screen Feb 27, 2026
@Dao-you Dao-you force-pushed the course-table branch 3 times, most recently from 342fd3e to 4276526 Compare February 28, 2026 12:57
@rileychh rileychh marked this pull request as draft February 28, 2026 15:21
Base automatically changed from course-table to main February 28, 2026 19:43
…and functionality

- Moved score-related utility functions and constants to score_view_helpers.dart.
- Created score_screen_actions.dart for handling score refresh and last updated caching.
- Updated ScoreScreen to utilize new helper functions and actions for better readability and maintainability.
- Enhanced academic performance provider to streamline data loading and caching logic.
@rileychh rileychh force-pushed the score-screen-and-student-service branch from 907cb3e to 91aa5fb Compare March 13, 2026 14:21
Keep main's getAcademicPerformance implementation and comments.
Only add new getGPA method and parser.
# Conflicts:
#	lib/database/database.g.dart
#	lib/database/schema.dart
#	lib/services/student_query/ntut_student_query_service.dart
#	lib/services/student_query/student_query_service.dart
Replace ~550-line score_providers.dart that manually called services
and handled DB persistence with a simple FutureProvider delegating to
StudentRepository.getSemesterRecords().
Add score section to zh-TW and en-US i18n YAMLs covering all
UI strings: load/refresh messages, empty states, summary card
labels, course number subtitle, and score status texts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants