Update Docker stuff #468
Open
Update Docker stuff #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
santaimpersonator
commented
Jun 29, 2021
santaimpersonator
commented
- Update some of the documentation
- Add compatible base image for pre-built images
- Improve printout for debugging
Move **BASE_IMAGE** configuration from /base `Dockerfile` to `configure.sh` script: - Set **JETBOT_BASE_IMAGE** as an environment variable - Pass variable to /base `Dockerfile`
Add a compatible base image, as mentioned in this issue: NVIDIA-AI-IOT#406 (comment) Works with latest pre-built images.
Add print statements to build script. Helps with debugging problems.
Include step to run `configuration.sh` script as mentioned in README: https://github.com/NVIDIA-AI-IOT/jetbot/tree/master/docker#step-1---configure-system
Add information for users to rebuild a container and step to check if the containers are running properly
Contributor
Author
|
I just realized that part of the changes are already in this pull request: #456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.