Skip to content

Conversation

@kalakris
Copy link

@kalakris kalakris commented Jan 15, 2026

Not sure if you accept patches on releases, but I don't think this applies to the latest version.

Summary

  • Fixes the git-lfs installation check that silently exits without showing an error message
  • The previous code used git lfs &>/dev/null followed by checking $?, but since the script uses set -e, the script exits immediately on the non-zero return code before reaching the print_error call

Root Cause

set -e  # line 11

git lfs &>/dev/null        # exits here with code 1
if [[ $? -ne 0 ]] ; then   # never reached
    print_error "..."      # never printed
fi

Fix

if ! git lfs &>/dev/null; then
    print_error "..."
fi

Fixes #151, #167, #176

The previous code used `git lfs &>/dev/null` followed by checking `$?`,
but since the script uses `set -e`, the script would exit immediately
on the non-zero return code before reaching the error message.

This also fixes the typo "insalled" -> "installed".

Fixes NVIDIA-ISAAC-ROS#151, NVIDIA-ISAAC-ROS#167, NVIDIA-ISAAC-ROS#176

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Happy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant