Skip to content

Improve randomization seed for generating node's random namespace #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvcyc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve randomization seed for generating node's random namespace #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63662a5
Improve randomization seed for generating node's random namespace
nvcyc Apr 19, 2024
45f132d
Add header for getpid()
nvcyc Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions isaac_ros_nitros/src/nitros_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
// Copyright (c) 2022-2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -15,6 +15,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include <unistd.h>
#include <filesystem>

#include <ament_index_cpp/get_package_share_directory.hpp>
Expand Down Expand Up @@ -56,7 +57,7 @@ const std::vector<std::string> PRESET_EXTENSION_SPEC_NAMES = {
namespace
{
// Generate a random string of the given length
unsigned int seed = time(NULL);
unsigned int seed = time(NULL) ^ getpid();
std::string GenerateRandomString(const size_t length)
{
std::string output_string;
Expand Down