Skip to content

[Fix] Correct RECLAIM_KEY digest in remove_kernel #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhdong merged 1 commit into from
Feb 18, 2026
Merged

[Fix] Correct RECLAIM_KEY digest in remove_kernel #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/merlin/core_kernels.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ __global__ void remove_kernel(const Table<K, V, S>* __restrict table,
if (pred(current_key, current_score, pattern, threshold)) {
atomicAdd(count, 1);
key_pos = key_offset;
bucket->digests(key_pos)[0] = empty_digest<K>();
bucket->digests(key_pos)[0] = reclaim_digest<K>();
(bucket->keys(key_pos))
->store(static_cast<K>(RECLAIM_KEY),
cuda::std::memory_order_relaxed);
Expand Down Expand Up @@ -815,7 +815,7 @@ __global__ void remove_kernel_v2(const uint64_t search_length,
}
// Only matched threads need to erase.
if (match) {
bucket->digests(key_idx)[0] = empty_digest<K>();
bucket->digests(key_idx)[0] = reclaim_digest<K>();
bucket->keys(key_idx)->store(static_cast<K>(RECLAIM_KEY),
cuda::std::memory_order_relaxed);
bucket->scores(key_idx)->store(static_cast<S>(EMPTY_SCORE),
Expand Down