Update feast to run on newest release version 0.31#975
Merged
jperez999 merged 9 commits intoNVIDIA-Merlin:mainfrom May 18, 2023
Merged
Update feast to run on newest release version 0.31#975jperez999 merged 9 commits intoNVIDIA-Merlin:mainfrom
jperez999 merged 9 commits intoNVIDIA-Merlin:mainfrom
Conversation
jperez999
requested review from
edknv,
karlhigley,
nv-alaiacano and
oliverholworthy
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation preview |
Contributor
|
@jperez999 It looks like the tests are failing due to downstream notebook tests, which we definitely should be running but probably should not be part of a required PR check. I think I did that, but it needs further attention, because those tests (while informative) should not block this PR. |
nv-alaiacano
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Merlin to run on latest version of feast by completing the following:
For this PR to work, the following PR must be merged first: NVIDIA-Merlin/systems#344 because it updates the feast operator.