Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/ISSUE_TEMPLATE/--new-model-addition.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
---
name: "\U0001F31F New model addition"
about: Submit a proposal/request to implement a new model
title: ''
title: ""
labels: New model
assignees: ''

assignees: ""
---

# 🌟 New model addition
Expand All @@ -15,6 +14,6 @@ assignees: ''

## Open source status

* [ ] the model implementation is available: (give details)
* [ ] the model weights are available: (give details)
* [ ] who are the authors: (mention them, if possible by @gh-username)
- [ ] the model implementation is available: (give details)
- [ ] the model weights are available: (give details)
- [ ] who are the authors: (mention them, if possible by @gh-username)
17 changes: 11 additions & 6 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,28 +3,33 @@ name: "\U0001F41B Bug Report"
about: Submit a bug report to help us improve Merlin Models
title: "[BUG]"
labels: "status/needs-triage, bug"
assignees: ''

assignees: ""
---

### Bug description

<!-- A clear and concise description of what the bug is. -->

### Steps/Code to reproduce bug

<!-- Follow this guide http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports to craft a minimal bug report. This helps us reproduce the issue you're having and resolve the issue more quickly. -->
1.
2.
3.

1.
2.
3.

### Expected behavior

<!-- A clear and concise description of what you expected to happen. -->

### Environment details
- Merlin version:

- Merlin version:
- Platform:
- Python version:
- PyTorch version (GPU?):
- Tensorflow version (GPU?):

### Additional context

<!-- Add any other context about the problem here. -->
12 changes: 9 additions & 3 deletions .github/ISSUE_TEMPLATE/documentation-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,33 +3,39 @@ name: Documentation request
about: Report incorrect or needed documentation
title: "[DOC]"
labels: "status/needs-triage, area/documentation"
assignees: ''

assignees: ""
---

## Report incorrect documentation

### Location of incorrect documentation

<!-- Provide links and line numbers if applicable. -->

### Describe the problems or issues found in the documentation

<!-- A clear and concise description of what you found to be incorrect. -->

### Steps taken to verify documentation is incorrect

<!-- List any steps you have taken: -->

### Suggested fix for documentation

<!-- Detail proposed changes to fix the documentation if you have any. -->

---

## Report needed documentation

### Report needed documentation

<!-- A clear and concise description of what documentation you believe it is needed and why. -->

### Describe the documentation you'd like

<!-- A clear and concise description of what you want to happen. -->

### Steps taken to search for needed documentation**
### Steps taken to search for needed documentation\*\*

<!-- List any steps you have taken: -->
5 changes: 2 additions & 3 deletions .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ name: "\U0001F680 Feature request"
about: Submit a proposal/request for a new Merlin Models feature
title: "[FEA]"
labels: "status/needs-triage, kind/feature-request"
assignees: ''

assignees: ""
---

# 🚀 Feature request
Expand All @@ -22,4 +21,4 @@ assignees: ''

<!-- Is there any way that you could help, e.g. by submitting a PR?
Make sure to read the CONTRIBUTING.MD readme:
https://github.com/NVIDIA-Merlin/models/blob/main/CONTRIBUTING.md -->
https://github.com/NVIDIA-Merlin/models/blob/main/CONTRIBUTING.md -->
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/submit-question.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ name: "❓ Questions & Help"
about: Ask a general question about Merlin Models
title: "[QST]"
labels: "status/needs-triage, kind/question"
assignees: ''

assignees: ""
---

# ❓ Questions & Help
Expand Down
5 changes: 1 addition & 4 deletions .github/ISSUE_TEMPLATE/task.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,10 @@ name: Task
about: A general task that we're tracking in Github
title: "[Task]"
labels: ""
assignees: ''

assignees: ""
---

### Description



**Additional context**
Add any other context, code examples, or references to existing implementations about the task here.
5 changes: 4 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Here are some guidelines to help the review process go smoothly.
3. If your pull request is ready to be reviewed without requiring additional
work on top of it, then remove the `status/work-in-progress` label (if present) and replace
it with `status/needs-review`. The additional changes then can be implemented on top of the
same PR.
same PR.

4. Once all work has been done and review has taken place please do not add
features or make changes out of the scope of those requested by the reviewer
Expand All @@ -33,12 +33,15 @@ Many thanks in advance for your cooperation!
Fixes # (issue)

### Goals :soccer:

<!-- List the high-level objectives of this pull request. -->
<!-- Include any relevant context. -->

### Implementation Details :construction:

<!-- Explain the reasoning behind any architectural changes. -->
<!-- Highlight any new functionality. -->

### Testing Details :mag:

<!-- Describe what tests you've added for your changes. -->
46 changes: 23 additions & 23 deletions .github/release-drafter.yml
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
name-template: 'v$RESOLVED_VERSION'
name-template: "v$RESOLVED_VERSION"
categories:
- title: '⚠ Breaking Changes'
labels:
- 'breaking'
- title: '🐜 Bug Fixes'
labels:
- 'bug'
- title: '🚀 Features'
labels:
- 'feature'
- 'enhancement'
- title: '📄 Documentation'
labels:
- 'documentation'
- 'examples'
- title: '🔧 Maintenance'
labels:
- 'build'
- 'dependencies'
- 'chore'
- 'ci'
change-template: '- $TITLE @$AUTHOR (#$NUMBER)'
- title: "⚠ Breaking Changes"
labels:
- "breaking"
- title: "🐜 Bug Fixes"
labels:
- "bug"
- title: "🚀 Features"
labels:
- "feature"
- "enhancement"
- title: "📄 Documentation"
labels:
- "documentation"
- "examples"
- title: "🔧 Maintenance"
labels:
- "build"
- "dependencies"
- "chore"
- "ci"
change-template: "- $TITLE @$AUTHOR (#$NUMBER)"
exclude-labels:
- 'skip-changelog'
- "skip-changelog"
template: |
## What’s Changed

Expand Down
46 changes: 23 additions & 23 deletions .github/workflows/cpu-nvtabular.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ name: nvtabular
on:
workflow_dispatch:
push:
branches: [ main ]
branches: [main]
tags:
- "v[0-9]+.[0-9]+.[0-9]+"
pull_request:
branches: [ main ]
branches: [main]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down Expand Up @@ -44,24 +44,24 @@ jobs:
os: [ubuntu-latest]

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install Ubuntu packages
run: |
sudo apt-get update -y
sudo apt-get install -y protobuf-compiler
- name: Install and upgrade python packages
run: |
python -m pip install --upgrade pip setuptools==59.4.0 wheel tox
- name: Get Merlin Branch name
id: get-branch-name
uses: NVIDIA-Merlin/.github/actions/branch-name@main
- name: Run tests
run: |
merlin_branch="${{ steps.get-branch-name.outputs.branch }}"
MERLIN_BRANCH="$merlin_branch" GIT_COMMIT=$(git rev-parse HEAD) tox -e py38-nvtabular-cpu
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install Ubuntu packages
run: |
sudo apt-get update -y
sudo apt-get install -y protobuf-compiler
- name: Install and upgrade python packages
run: |
python -m pip install --upgrade pip setuptools==59.4.0 wheel tox
- name: Get Merlin Branch name
id: get-branch-name
uses: NVIDIA-Merlin/.github/actions/branch-name@main
- name: Run tests
run: |
merlin_branch="${{ steps.get-branch-name.outputs.branch }}"
MERLIN_BRANCH="$merlin_branch" GIT_COMMIT=$(git rev-parse HEAD) tox -e py38-nvtabular-cpu
46 changes: 23 additions & 23 deletions .github/workflows/cpu-systems.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ name: systems
on:
workflow_dispatch:
push:
branches: [ main ]
branches: [main]
tags:
- "v[0-9]+.[0-9]+.[0-9]+"
pull_request:
branches: [ main ]
branches: [main]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down Expand Up @@ -44,24 +44,24 @@ jobs:
os: [ubuntu-latest]

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install Ubuntu packages
run: |
sudo apt-get update -y
sudo apt-get install -y protobuf-compiler
- name: Install and upgrade python packages
run: |
python -m pip install --upgrade pip setuptools==59.4.0 wheel tox
- name: Get Merlin Branch name
id: get-branch-name
uses: NVIDIA-Merlin/.github/actions/branch-name@main
- name: Run tests
run: |
merlin_branch="${{ steps.get-branch-name.outputs.branch }}"
MERLIN_BRANCH="$merlin_branch" GIT_COMMIT=$(git rev-parse HEAD) tox -e py38-systems-cpu
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install Ubuntu packages
run: |
sudo apt-get update -y
sudo apt-get install -y protobuf-compiler
- name: Install and upgrade python packages
run: |
python -m pip install --upgrade pip setuptools==59.4.0 wheel tox
- name: Get Merlin Branch name
id: get-branch-name
uses: NVIDIA-Merlin/.github/actions/branch-name@main
- name: Run tests
run: |
merlin_branch="${{ steps.get-branch-name.outputs.branch }}"
MERLIN_BRANCH="$merlin_branch" GIT_COMMIT=$(git rev-parse HEAD) tox -e py38-systems-cpu
Loading