Pass mpi environment variable to tox#1136
Merged
oliverholworthy merged 1 commit intoNVIDIA-Merlin:mainfrom Jun 6, 2023
Merged
Conversation
edknv
force-pushed
the
ci/horovod-env-var-tox
branch
from
3f5ce54 to
dc17c71
Compare
Documentation preview |
edknv
force-pushed
the
ci/horovod-env-var-tox
branch
from
dc17c71 to
c4f7495
Compare
oliverholworthy
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR passes the necessary environment from the ci-runner to tox. The
OPAL_PREFIXis available if Open MPI is available and horovod is installed with MPI enabled, but tox blocks all environments by default and running tests in tox will produce import errors like the one in #1134 for example.