Skip to content

Set upper bound on transformers dependency to <4.30#1140

Closed
oliverholworthy wants to merge 1 commit intoNVIDIA-Merlin:mainfrom
oliverholworthy:transformers-version-pin
Closed

Set upper bound on transformers dependency to <4.30#1140
oliverholworthy wants to merge 1 commit intoNVIDIA-Merlin:mainfrom
oliverholworthy:transformers-version-pin

Conversation

@oliverholworthy
Copy link
Contributor

@oliverholworthy oliverholworthy commented Jun 9, 2023

Fixes Error we're seeing in our tests with TensorFlow versions prior to 2.11

/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/transformers/modeling_tf_utils.py:84: in <module>
    from tensorflow.python.keras.engine import call_context
E   ImportError: cannot import name 'call_context' from 'tensorflow.python.keras.engine' (/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/tensorflow/python/keras/engine/__init__.py)

The newest version of the transformers package 4.30.0 started importing a module that only exists in TensorFlow 2.11 and above.

Setting this upper bound for now until we drop support for TensorFlow 2.10 and earlier, or this is updated in transformers to restore support for earlier versions of TensorFlow (related issue here)

@oliverholworthy oliverholworthy added the chore Maintenance for the repository label Jun 9, 2023
@oliverholworthy oliverholworthy self-assigned this Jun 9, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.06 milestone Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1140

@oliverholworthy
Copy link
Contributor Author

4.30.1 of transformers was released with a fix that restores support for earlier versions of TensorFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance for the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant