Closed
Conversation
Contributor
|
Yeah, I think we should go the other direction and make it possible to use |
Documentation preview |
Contributor
Author
|
Does it seem reasonable to add the requirement to ensure that it works for the upcoming release, then remove that requirement when we remove the dependency on it in the Ensemble code? |
Contributor
|
Sure, I guess that could work 🤷🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tritonclientlibrary seems to be required in order to construct an Ensemble. I imagine that we could work around this by having a non-Triton runtime as the default setting for Ensembles. But ifTritonExecutorRuntimeis going to be the default runtime, we should include the tritonclient library in systems.Sample single-node workflow to reproduce:
The error I get: