You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
match_representations was implemented a bit weirdly and seems to have had corner cases we weren't tracking. This updates the implementation to be less clever and more straightforward, which also makes it work better.
karlhigley
changed the title
Fix _to_values_offsets handle converting 1d values
Fix the code that aligns returned data with the output schema
Apr 24, 2023
match_representations was implemented a bit weirdly and seems to have had corner cases we weren't tracking. This updates the implementation to be less clever and more straightforward, which also makes it work better.
By 'work better', is this about filtering out columns that are not present in the schema from the data passed to match representations?
By 'work better', is this about filtering out columns that are not present in the schema from the data passed to match representations?
It wasn't intended to do that, but I suppose it may have that effect. TBH, the first implementation was a bit clever and hard to think about, so instead of trying to fix it we just started over from scratch and wrote it in a fashion that was easier to understand. Once we did that, tests started passing so we called it a win. (In particular, the test for Radek's TF transformer next-item prediction example notebook.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
match_representationswas implemented a bit weirdly and seems to have had corner cases we weren't tracking. This updates the implementation to be less clever and more straightforward, which also makes it work better.