Skip to content

add test requirements to postmerge gpu#347

Merged
jperez999 merged 2 commits intomainfrom
laiacano/postmerge-tox-fix
May 17, 2023
Merged

add test requirements to postmerge gpu#347
jperez999 merged 2 commits intomainfrom
laiacano/postmerge-tox-fix

Conversation

@nv-alaiacano
Copy link
Contributor

This should get the post-merge GPU job running again (at least it did locally).

Note that I modified the action triggers to run pre merge as well. I want that so i can test the action before merging a PR.

@nv-alaiacano nv-alaiacano added this to the Merlin 23.06 milestone May 16, 2023
@nv-alaiacano nv-alaiacano self-assigned this May 16, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/systems/review/pr-347

@nv-alaiacano
Copy link
Contributor Author

gpu-ci-postmerge is still failing, but failing in the right way. Here are the logs:

Before this change: https://github.com/NVIDIA-Merlin/systems/actions/runs/4993264364/jobs/8942125181
After this change: https://github.com/NVIDIA-Merlin/systems/actions/runs/4995615240/jobs/8947705787?pr=347

@nv-alaiacano nv-alaiacano requested a review from jperez999 May 16, 2023 20:28
@nv-alaiacano nv-alaiacano marked this pull request as ready for review May 16, 2023 20:28
@jperez999 jperez999 merged commit e3e91c3 into main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants