Skip to content

Fix reading parquet files in examples#348

Merged
oliverholworthy merged 4 commits intomainfrom
laiacano/integration-test-fixes
Jun 13, 2023
Merged

Fix reading parquet files in examples#348
oliverholworthy merged 4 commits intomainfrom
laiacano/integration-test-fixes

Conversation

@nv-alaiacano
Copy link
Contributor

cudf.read_parquet doesn't have a num_rows parameter, so this fails on GPU-based tests. Instead I read in the whole thing and take the top 3 rows - less efficient, but working for test/example purposes.

@nv-alaiacano nv-alaiacano added the bug Something isn't working label May 18, 2023
@nv-alaiacano nv-alaiacano added this to the Merlin 23.05 milestone May 18, 2023
@nv-alaiacano nv-alaiacano requested a review from jperez999 May 18, 2023 14:53
@nv-alaiacano nv-alaiacano self-assigned this May 18, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/systems/review/pr-348

@oliverholworthy oliverholworthy merged commit 0d8ca65 into main Jun 13, 2023
@oliverholworthy oliverholworthy deleted the laiacano/integration-test-fixes branch June 13, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants