Update test_export_merlin_models test to run on dynamic dask cluster type#355
Merged
nv-alaiacano merged 1 commit intoNVIDIA-Merlin:mainfrom May 31, 2023
Merged
Conversation
Documentation preview |
oliverholworthy
changed the title
test_export_merlin_models test to run on dynamic dask cluster type
oliverholworthy
force-pushed
the
fil-dask-gpu-test
branch
2 times, most recently
from
00464ae to
9813fda
Compare
nv-alaiacano
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cluster_type="cpu"fromtest_export_merlin_modelsmerlin.io.Datasetby default constructs a dask_cudf dataframe if a GPU is available, and when running this on a dask CPU cluster, we get unmanaged memory errors. Ideally if this is a known compatibility issue, it would be preferable to get a RuntimeError or similar indicating that when using a dask CPU based LocalCluster, a regular dask dataframe should be used intead.