Skip to content

Fix Pytorch integration test postmerge test#363

Merged
oliverholworthy merged 6 commits intoNVIDIA-Merlin:mainfrom
oliverholworthy:ci-post-merge-pytorch-test
Jun 8, 2023
Merged

Fix Pytorch integration test postmerge test#363
oliverholworthy merged 6 commits intoNVIDIA-Merlin:mainfrom
oliverholworthy:ci-post-merge-pytorch-test

Conversation

@oliverholworthy
Copy link
Contributor

Fix Pytorch integration test postmerge test

  • Extends LD_LIBRARY_PATH instead of replacing it completely
    • This was causing an error CUDA driver version is insufficient for CUDA runtime version
    • I suspect this might be due to a combination of other CUDA-related enviroment variables that are not passed through to the tox environment.
  • Extends match_representations type coercion to work with torch tensors

@oliverholworthy oliverholworthy self-assigned this Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Documentation preview

https://nvidia-merlin.github.io/systems/review/pr-363

@oliverholworthy
Copy link
Contributor Author

Postmerge tests succeeded here

@oliverholworthy oliverholworthy marked this pull request as ready for review June 8, 2023 12:53
@oliverholworthy oliverholworthy added this to the Merlin 23.06 milestone Jun 8, 2023
@oliverholworthy oliverholworthy merged commit 399ef23 into NVIDIA-Merlin:main Jun 8, 2023
@oliverholworthy oliverholworthy deleted the ci-post-merge-pytorch-test branch June 8, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants