Remove use_gpu argument from Implicit model example notebook#369
Merged
oliverholworthy merged 1 commit intoNVIDIA-Merlin:mainfrom Jun 12, 2023
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation preview |
jperez999
approved these changes
Jun 12, 2023
Collaborator
|
This means that in the next release we will have a hard dependency on merlin-models 23.06 right? Or does merlin models implicit support already have this feature? Where it autoloads the model on GPU if possible? What happens if the user wants to use CPU even in a GPU environment? |
Contributor
Author
I don't think this PR adds any dependency, merlin-models is not part of the |
nv-alaiacano
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
use_gpuargument from the Implicit model example notebook (examples/Serving-An-Implicit-Model-With-Merlin-Systems.ipynb).This is to support running this notebook as an integration test in a CUDA 12 Environment. Implicit currnently supports CUDA 11.
The model class we're calling should select the GPU version if it can successfully load the GPU accelerated version (currenlty in a CUDA 11 environment)