Conversation
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
e1a77c6 to
4359e8a
Compare
Contributor
Author
|
/ok to test f2938d7 |
adil-a
approved these changes
Feb 24, 2026
Collaborator
adil-a
left a comment
There was a problem hiding this comment.
LGTM, thanks @oliverholworthy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
load_datasets()inretrieval_dataset.py: resolve relativepathentries in thecorpusconfig before passing them toadd_corpus()Tests
test_load_datasets_resolves_relative_corpus_pathtest_retrieval_dataset.pytests passBefore your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.