Skip to content

Conversation

@jrbourbeau
Copy link
Member

These both raise errors like this

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[2], line 1
----> 1 writer = JsonlWriter(output_dir="./cc_output")

TypeError: JsonlWriter.__init__() got an unexpected keyword argument 'output_dir'

This PR updates these snippets to pass the output directory as a positional argument instead

Signed-off-by: James Bourbeau <[email protected]>
@jrbourbeau jrbourbeau changed the title Fix JsonlWriter output directory typo Fix JsonlWriter / ParquetWriter output directory typo Oct 14, 2025
@praateekmahajan praateekmahajan enabled auto-merge (squash) October 16, 2025 16:27
@praateekmahajan praateekmahajan merged commit d01756f into NVIDIA-NeMo:main Oct 16, 2025
11 checks passed
@jrbourbeau
Copy link
Member Author

Thanks @praateekmahajan!

@jrbourbeau jrbourbeau deleted the jsonlwriter-typo branch October 16, 2025 16:46
lbliii pushed a commit to lbliii/NeMo-Curator that referenced this pull request Oct 22, 2025
jnke2016 pushed a commit to jnke2016/Curator that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants