Fix flaky test_split_parquet_file_by_size failure
#1185
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Bourbeau <[email protected]>
Signed-off-by: James Bourbeau <[email protected]>
lbliii
pushed a commit
to lbliii/NeMo-Curator
that referenced
this pull request
Oct 22, 2025
* Log more info on test_split_parquet_file_by_size failure Signed-off-by: James Bourbeau <[email protected]> * Sort files Signed-off-by: James Bourbeau <[email protected]> --------- Signed-off-by: James Bourbeau <[email protected]> Co-authored-by: Ayush Dattagupta <[email protected]> Signed-off-by: Lawrence Lane <[email protected]>
jnke2016
pushed a commit
to jnke2016/Curator
that referenced
this pull request
Nov 12, 2025
* Log more info on test_split_parquet_file_by_size failure Signed-off-by: James Bourbeau <[email protected]> * Sort files Signed-off-by: James Bourbeau <[email protected]> --------- Signed-off-by: James Bourbeau <[email protected]> Co-authored-by: Ayush Dattagupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #1184 (comment)
EDIT: The issue was the files we get from
Path.rglobaren't always sorted. This PR adds an explicitsorted(...)callCloses #1184