-
Notifications
You must be signed in to change notification settings - Fork 205
Remove nvenc/dec for xenna 0.1.6 #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ao Tang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, 1 comment
| if self.entire_gpu: | ||
| self.gpus = 1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: When entire_gpu=True, self.gpus is set to 1.0 after validation checks. If user also sets gpu_memory_gb > 0, the validation on line 52 will fail before reaching this code, which is correct. However, if user sets both entire_gpu=True and gpus > 0, this assignment will silently overwrite their explicit gpus value without raising an error. Should there be a validation check to prevent setting both entire_gpu=True and gpus > 0 explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly think the best is to drop entire_gpu and only provide gpu_memory_gb and gpus. @ayushdg @praateekmahajan what do you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this, entire_gpu has been confusing for me the whole time it existed. I think it was there for nvenc/nvdec reasons (which I never understood well). So if we're nuking nvenc/nvdec support this should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed let's just drop this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make a seperate issue for this to track. Let's keep it seperate. Wanna make sure we do it properly across documentation and code and stuff
Signed-off-by: Ao Tang <[email protected]>
|
/ok to test d9f705a |
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
Description
Linked issue: #1201
For Video Transcoding stage, use similar logic as https://github.com/nvidia-cosmos/cosmos-curate/blob/main/cosmos_curate/pipelines/video/clipping/clip_extraction_stages.py#L198 to partition gpu based on _nb_streams_per_gpu.
Usage
# Add snippet demonstrating usageChecklist