-
Notifications
You must be signed in to change notification settings - Fork 205
Add Code Examples to Video Tutorial #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ao Tang <[email protected]>
Greptile SummaryThis PR significantly enhances the video tutorial documentation by adding comprehensive Python API code examples. The changes transform a CLI-focused tutorial into a complete guide showing both command-line and programmatic approaches. Major additions:
Issue found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Tutorial as README.md
participant CLI as video_split_clip_example.py
participant API as NeMo Curator API
User->>Tutorial: Read documentation
Note over Tutorial: Quick Start section shows<br/>CLI usage
Tutorial->>User: Shows CLI command examples
User->>Tutorial: Learn programmatic usage
Note over Tutorial: New "Programmatic API Usage"<br/>section added
Tutorial->>User: Shows Python API examples<br/>(VideoReader, Pipeline, Stages)
alt Command Line Usage
User->>CLI: Run video_split_clip_example.py
CLI->>API: Creates Pipeline with stages
API->>API: Execute video curation workflow
API->>User: Output clips + metadata
else Programmatic Usage
User->>API: Import stages and build Pipeline
User->>API: Add VideoReader, Extractors, Filters
User->>API: Run pipeline with XennaExecutor
API->>User: Output clips + embeddings + metadata
end
Note over Tutorial: Sections include:<br/>- Basic Splitting<br/>- Scene Detection (TransNetV2)<br/>- Embeddings (Cosmos/InternVideo2)<br/>- Quality Filters<br/>- Caption Generation<br/>- Complete Examples
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| ### Cosmos-Embed1 (Recommended) | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: Section header for Cosmos-Embed1 is empty/incomplete.
| ### Cosmos-Embed1 (Recommended) | |
| ### Cosmos-Embed1 (Recommended) | |
| Cosmos-Embed1 provides high-quality video embeddings with 768 dimensions. It offers better performance than InternVideo2 for most use cases. |
Description
Usage
# Add snippet demonstrating usageChecklist