Skip to content

Conversation

@suiyoubi
Copy link
Contributor

@suiyoubi suiyoubi commented Jan 2, 2026

Description

Usage

# Add snippet demonstrating usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 2, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 2, 2026

Greptile Summary

This PR significantly enhances the video tutorial documentation by adding comprehensive Python API code examples. The changes transform a CLI-focused tutorial into a complete guide showing both command-line and programmatic approaches.

Major additions:

  • New "Programmatic API Usage" section with detailed code examples
  • Basic video splitting pipeline with VideoReader, FixedStrideExtractorStage, and ClipTranscodingStage
  • Scene-aware splitting using TransNetV2ClipExtractionStage
  • Video embeddings with CosmosEmbed1 stages
  • Quality filtering examples (ClipAestheticFilterStage, MotionFilterStage)
  • Caption generation workflow with CaptionPreparationStage, CaptionGenerationStage, and CaptionEnhancementStage
  • Complete end-to-end pipeline example combining multiple features
  • Reorganized CLI examples under "Command Line Examples" section
  • Better structured embedding model comparison (Cosmos-Embed1 vs InternVideo2)

Issue found:

  • Lines 363-365: Empty section header for "Cosmos-Embed1 (Recommended)" needs descriptive content

Confidence Score: 4/5

  • This PR is safe to merge with one minor documentation fix needed
  • The PR adds extensive documentation with code examples that align with the actual codebase implementation. All imports and API usage appear correct based on the existing video_split_clip_example.py file. The only issue is an incomplete section header that needs content added, which is a documentation formatting issue rather than a code problem.
  • The Cosmos-Embed1 section header on lines 363-365 needs descriptive content added before merging

Important Files Changed

Filename Overview
tutorials/video/getting-started/README.md Expanded tutorial with comprehensive Python API examples and code snippets. One incomplete section header needs content (Cosmos-Embed1 description).

Sequence Diagram

sequenceDiagram
    participant User
    participant Tutorial as README.md
    participant CLI as video_split_clip_example.py
    participant API as NeMo Curator API
    
    User->>Tutorial: Read documentation
    Note over Tutorial: Quick Start section shows<br/>CLI usage
    Tutorial->>User: Shows CLI command examples
    
    User->>Tutorial: Learn programmatic usage
    Note over Tutorial: New "Programmatic API Usage"<br/>section added
    Tutorial->>User: Shows Python API examples<br/>(VideoReader, Pipeline, Stages)
    
    alt Command Line Usage
        User->>CLI: Run video_split_clip_example.py
        CLI->>API: Creates Pipeline with stages
        API->>API: Execute video curation workflow
        API->>User: Output clips + metadata
    else Programmatic Usage
        User->>API: Import stages and build Pipeline
        User->>API: Add VideoReader, Extractors, Filters
        User->>API: Run pipeline with XennaExecutor
        API->>User: Output clips + embeddings + metadata
    end
    
    Note over Tutorial: Sections include:<br/>- Basic Splitting<br/>- Scene Detection (TransNetV2)<br/>- Embeddings (Cosmos/InternVideo2)<br/>- Quality Filters<br/>- Caption Generation<br/>- Complete Examples
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines +363 to +365
### Cosmos-Embed1 (Recommended)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Section header for Cosmos-Embed1 is empty/incomplete.

Suggested change
### Cosmos-Embed1 (Recommended)
### Cosmos-Embed1 (Recommended)
Cosmos-Embed1 provides high-quality video embeddings with 768 dimensions. It offers better performance than InternVideo2 for most use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants