-
Notifications
You must be signed in to change notification settings - Fork 215
cp: Purge InternVideo2 (1451) into r1.1.0
#1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Remove Internvideo2 Signed-off-by: Ao Tang <aot@nvidia.com> * more to remove Signed-off-by: Ao Tang <aot@nvidia.com> * fix writer Signed-off-by: Ao Tang <aot@nvidia.com> * Enhance Clip class to include cosmos_embed1_frames and cosmos_embed1_embedding in total size calculation Signed-off-by: Ao Tang <aot@nvidia.com> * remove iv2 Signed-off-by: Ao Tang <aot@nvidia.com> --------- Signed-off-by: Ao Tang <aot@nvidia.com> Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
|
/ok to test 796fbcd |
Greptile OverviewGreptile SummaryCherry-pick of PR #1451 that completely removes InternVideo2 embedding support from the codebase, standardizing on Cosmos-Embed1 as the sole video embedding model. Key Changes:
Impact: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PR as PR #1451
participant Code as Codebase
participant Docker as Docker Build
participant CI as CI/CD Pipeline
participant Tests as Test Suite
participant Docs as Documentation
Note over Dev,Docs: InternVideo2 Removal Process
Dev->>Code: Remove InternVideo2 model files
Code-->>Dev: Delete internvideo2_mm.py, internvideo2.py
Dev->>Code: Remove InternVideo2 stages
Code-->>Dev: Delete InternVideo2EmbeddingStage, InternVideo2FrameCreationStage
Dev->>Code: Update Clip dataclass
Note right of Code: Remove intern_video_2_frames<br/>Remove intern_video_2_embedding<br/>Remove intern_video_2_text_match<br/>Fix duplicate size calculation
Dev->>Code: Update ClipWriterStage
Note right of Code: Remove _iv2_embedding_buffer<br/>Remove InternVideo2 embedding logic<br/>Update cosmos-embed1 check to .startswith()
Dev->>Docker: Remove InternVideo2 from Dockerfile
Docker-->>Dev: Remove git clone, patch, and uv add steps
Dev->>CI: Update CI/CD workflow
CI-->>Dev: Remove InternVideo2 cache and checkout steps
Dev->>Tests: Update test suite
Tests-->>Dev: Remove InternVideo2 tests<br/>Update assertions to use Cosmos-Embed1
Dev->>Docs: Update documentation
Docs-->>Dev: Remove InternVideo2 references<br/>Update embedding algorithm docs<br/>Update tutorials and examples
Dev->>PR: Cherry-pick to r1.1.0
PR->>Code: Apply all changes to release branch
Note over Code,Tests: Result: Cosmos-Embed1 is now<br/>the only supported embedding model
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 files reviewed, no comments
beep boop [🤖]: Hi @suiyoubi 👋,